Rotate is not bit-exact in a radian scene or for multi-channel results
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 22/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Active
- Tech stack
- rust
- Domain
- computer-graphics, desktop
Research direction
The payload names no files or tests, so locate the Rotate code path and its history entry first, looking for where radians are converted to degrees and back. Reproduce by rotating in a radian scene and comparing the stored value with baseline plus delta. Done when that value is bit-exact and untouched channels stay byte-identical, including for multi-channel Euler results. The issue suggests storing the requested value in scene units, which is a design change, so check with the maintainer first.
Written by the indexing model from the issue text.
Description
Rotate works internally in degrees. A Rotate that changes exactly one channel by the requested delta now stores baseline + delta in the scene's declared unit, bit for bit (object-space X ring, single-channel numeric entry, and Y/Z or world rotations whose decomposition changes one channel within the snap tolerance).
Still computed rather than exact, within about 1 ulp:
- A radian scene: a requested radian angle is converted to degrees and back.
- A Y/Z ring or world rotation that genuinely changes several channels (Euler decomposition).
Goal of this issue: make the radian path exact, for example by carrying the requested value in scene units through the history instead of converting to degrees. Untouched channels are preserved byte for byte.
- Dominant language
- Rust
- Stars
- 4
- Forks
- 2
- Avg merge
- 2h 28m
- Merged PRs (30d)
- 76
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from cristim/AztecCraft
-
area/viewport type/chore
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
cristim/AztecCraft#186 ·
Maintainers usually reply within 1 day
-
area/infra type/chore
Difficulty 1/5 Under an hour Newbie friendliness 94/100
cristim/AztecCraft#181 ·
Maintainers usually reply within 1 day
-
area/modeling type/bug
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
cristim/AztecCraft#176 ·
Maintainers usually reply within 1 day
-
area/modeling type/bug
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
cristim/AztecCraft#175 ·
Maintainers usually reply within 1 day
-
area/ui-parity type/bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
cristim/AztecCraft#172 · 1 comment ·
Maintainers usually reply within 1 day
All issues in cristim/AztecCraft
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
nautechsystems/nautilus_trader#5365 ·
Maintainers usually reply within 1 day
-
documentation
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
IntersectMBO/developer-experience#347 ·
Maintainers usually reply within 2 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
registrystack/registry-stack#2168 ·
Maintainers usually reply within 1 day
-
bug crate: 3d help wanted triage
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
kornia/kornia-rs#1203 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
Maintainers usually reply within 1 day