install: --composefs-backend ignores install config kargs, karg-deletes and --karg-delete
Maintainers usually reply within 2 days
Nobody has claimed this yet.
- #42 by @cgwalters-bot — closed without merging
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 68/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- rust
- Domain
- operating-systems
Research direction
Start with install_container in crates/lib/src/install.rs and the composefs BLS-entry and compute_new_kargs paths in crates/lib/src/bootc_composefs/boot.rs. Read the plan-40-install-karg-delete skip in tmt/plans/integration.fmf and the related tests; reproduce the to-disk case described here. Done means composefs applies install-config kargs and both delete sources like the ostree path, or clearly rejects unsupported options.
Written by the indexing model from the issue text.
Description
With --composefs-backend, bootc install to-disk ignores kargs and karg-deletes from the install config, and the --karg-delete option. The config kargs are missing from the kernel command line, and the deletes leave their kargs in place. The install exits 0 without a warning. The same install without --composefs-backend applies all three.
Reproduced on quay.io/fedora/fedora-bootc:44 (bootc 1.16.13) with this derived image:
FROM quay.io/fedora/fedora-bootc:44@sha256:5ab8ee5189bb0f3870279723f5343474df002d8d6f46564702b3ad3ba7382d98
COPY 10-gapbase.toml /usr/lib/bootc/kargs.d/10-gapbase.toml
COPY 50-gaps.toml /usr/lib/bootc/install/50-gaps.toml
# 10-gapbase.toml
kargs = ["gapdel=1", "gapclidel=1"]
# 50-gaps.toml
[install]
kargs = ["gapcfg=1"]
karg-deletes = ["gapdel=1"]
podman build -t localhost/gaprepro:1 .
truncate -s 20G a.raw b.raw
podman run --rm --privileged --pid=host --security-opt label=type:unconfined_t \
-v /dev:/dev -v /var/lib/containers:/var/lib/containers -v $PWD:/out localhost/gaprepro:1 \
bootc install to-disk --via-loopback --filesystem ext4 --generic-image --wipe \
--composefs-backend --karg-delete=gapclidel=1 /out/a.raw
# the same again without --composefs-backend, writing b.raw
/proc/cmdline after booting each disk, from rw onwards:
composefs: rw composefs=52e75610b743... gapdel=1 gapclidel=1
ostree: rw gapcfg=1 ostree=/ostree/boot.1/default/2e3c2da7.../0
The ostree path adds the install config kargs and kargs.d, then applies karg-deletes and --karg-delete, in install_container (install.rs L1217-L1252). The composefs BLS entry takes root_setup.kargs and --karg (boot.rs L782-L791) and adds kargs.d through compute_new_kargs (L865), and nothing under bootc_composefs reads install_config or karg_delete. plan-40-install-karg-delete is skipped on composefs (integration.fmf L252-L258).
#2304 and #2305 covered --karg on this path; these are the remaining kernel argument options. I'd expect composefs installs to apply them as ostree installs do, or to reject them. I only tested to-disk with BLS entries.
- Dominant language
- Rust
- Stars
- 2.3k
- Forks
- 230
- Avg merge
- 2d 11h
- Merged PRs (30d)
- 42
Getting set up
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from bootc-dev/bootc
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
Maintainers usually reply within 2 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Maintainers usually reply within 2 days
-
install: improve error message when systemd-boot is selected without composefs backendMay be free again A pull request for this issue was closed without being merged. Open
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
Maintainers usually reply within 2 days
-
Difficulty 4/5 3-5 days Newbie friendliness 55/100
Maintainers usually reply within 2 days
-
Difficulty 5/5 Over a week Newbie friendliness 30/100
Maintainers usually reply within 2 days
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
-
Wait for the IDS correction dialog to settle in the stale-audit testPossibly taken @louistrue claimed this today. Openready
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Maintainers usually reply within 1 day
-
good first issue help wanted
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
dutchman-cad/dutchman#874 ·
Maintainers usually reply within 1 day
-
bug good first issue ready
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
MartinPTielemans/ilo#3840 ·
Maintainers usually reply within 1 day
-
bug file-compat priority: medium
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
storytold/wordcraft#7248 · 1 comment ·
Maintainers usually reply within 4 days