install: --composefs-backend ignores install config kargs, karg-deletes and --karg-delete
维护者通常 2 天内回复
还没有人认领这个 Issue。
- #42 来自 @cgwalters-bot —— 已关闭,未合并
评估
- 难度
- 3/5
- 预计耗时
- 1-2 天
- 新手友好度
- 68/100
- Issue 类型
- 缺陷
- 描述清晰度
- 描述清楚
- 活跃度
- 活跃
- 技术栈
- rust
调研方向
Start with install_container in crates/lib/src/install.rs and the composefs BLS-entry and compute_new_kargs paths in crates/lib/src/bootc_composefs/boot.rs. Read the plan-40-install-karg-delete skip in tmt/plans/integration.fmf and the related tests; reproduce the to-disk case described here. Done means composefs applies install-config kargs and both delete sources like the ostree path, or clearly rejects unsupported options.
由索引模型根据 Issue 内容生成。
描述
With --composefs-backend, bootc install to-disk ignores kargs and karg-deletes from the install config, and the --karg-delete option. The config kargs are missing from the kernel command line, and the deletes leave their kargs in place. The install exits 0 without a warning. The same install without --composefs-backend applies all three.
Reproduced on quay.io/fedora/fedora-bootc:44 (bootc 1.16.13) with this derived image:
FROM quay.io/fedora/fedora-bootc:44@sha256:5ab8ee5189bb0f3870279723f5343474df002d8d6f46564702b3ad3ba7382d98
COPY 10-gapbase.toml /usr/lib/bootc/kargs.d/10-gapbase.toml
COPY 50-gaps.toml /usr/lib/bootc/install/50-gaps.toml
# 10-gapbase.toml
kargs = ["gapdel=1", "gapclidel=1"]
# 50-gaps.toml
[install]
kargs = ["gapcfg=1"]
karg-deletes = ["gapdel=1"]
podman build -t localhost/gaprepro:1 .
truncate -s 20G a.raw b.raw
podman run --rm --privileged --pid=host --security-opt label=type:unconfined_t \
-v /dev:/dev -v /var/lib/containers:/var/lib/containers -v $PWD:/out localhost/gaprepro:1 \
bootc install to-disk --via-loopback --filesystem ext4 --generic-image --wipe \
--composefs-backend --karg-delete=gapclidel=1 /out/a.raw
# the same again without --composefs-backend, writing b.raw
/proc/cmdline after booting each disk, from rw onwards:
composefs: rw composefs=52e75610b743... gapdel=1 gapclidel=1
ostree: rw gapcfg=1 ostree=/ostree/boot.1/default/2e3c2da7.../0
The ostree path adds the install config kargs and kargs.d, then applies karg-deletes and --karg-delete, in install_container (install.rs L1217-L1252). The composefs BLS entry takes root_setup.kargs and --karg (boot.rs L782-L791) and adds kargs.d through compute_new_kargs (L865), and nothing under bootc_composefs reads install_config or karg_delete. plan-40-install-karg-delete is skipped on composefs (integration.fmf L252-L258).
#2304 and #2305 covered --karg on this path; these are the remaining kernel argument options. I'd expect composefs installs to apply them as ostree installs do, or to reject them. I only tested to-disk with BLS entries.
- 主要语言
- Rust
- 星标
- 2.3k
- 派生
- 230
- 平均合并
- 2 天 11 小时
- 30 天内合并 PR
- 42
环境准备
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
bootc-dev/bootc 的其他 Issue
-
难度 2/5 1-3 小时 新手友好度 76/100
维护者通常 2 天内回复
-
难度 2/5 1-3 小时 新手友好度 68/100
维护者通常 2 天内回复
-
install: improve error message when systemd-boot is selected without composefs backend可能重新可做 关联的 PR 已关闭且未合并。 未关闭
难度 2/5 1-3 小时 新手友好度 76/100
维护者通常 2 天内回复
-
难度 4/5 3-5 天 新手友好度 55/100
维护者通常 2 天内回复
-
难度 5/5 一周以上 新手友好度 30/100
维护者通常 2 天内回复
相似的 Issue
-
难度 2/5 1-3 小时 新手友好度 70/100
-
Wait for the IDS correction dialog to settle in the stale-audit test可能已有人在做 @louistrue 今天认领。 未关闭ready
难度 2/5 1-3 小时 新手友好度 68/100
维护者通常 1 天内回复
-
good first issue help wanted
难度 2/5 1-3 小时 新手友好度 70/100
dutchman-cad/dutchman#874 ·
维护者通常 1 天内回复
-
bug good first issue ready
难度 2/5 1-3 小时 新手友好度 78/100
MartinPTielemans/ilo#3840 ·
维护者通常 1 天内回复
-
bug file-compat priority: medium
难度 2/5 1-3 小时 新手友好度 68/100
storytold/wordcraft#7248 · 1 条评论 ·
维护者通常 4 天内回复