install: --composefs-backend ignores install config kargs, karg-deletes and --karg-delete

Aperta
#2,539 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 2 giorni

Nessuno ha ancora preso questa issue.

  • #42 di @cgwalters-bot — chiusa senza merge

Valutazione

Difficoltà
3/5
Tempo stimato
1-2 giorni
Idoneità per principianti
68/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
rust

Direzione di ricerca

Start with install_container in crates/lib/src/install.rs and the composefs BLS-entry and compute_new_kargs paths in crates/lib/src/bootc_composefs/boot.rs. Read the plan-40-install-karg-delete skip in tmt/plans/integration.fmf and the related tests; reproduce the to-disk case described here. Done means composefs applies install-config kargs and both delete sources like the ostree path, or clearly rejects unsupported options.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

With --composefs-backend, bootc install to-disk ignores kargs and karg-deletes from the install config, and the --karg-delete option. The config kargs are missing from the kernel command line, and the deletes leave their kargs in place. The install exits 0 without a warning. The same install without --composefs-backend applies all three.

Reproduced on quay.io/fedora/fedora-bootc:44 (bootc 1.16.13) with this derived image:

FROM quay.io/fedora/fedora-bootc:44@sha256:5ab8ee5189bb0f3870279723f5343474df002d8d6f46564702b3ad3ba7382d98
COPY 10-gapbase.toml /usr/lib/bootc/kargs.d/10-gapbase.toml
COPY 50-gaps.toml /usr/lib/bootc/install/50-gaps.toml
# 10-gapbase.toml
kargs = ["gapdel=1", "gapclidel=1"]

# 50-gaps.toml
[install]
kargs = ["gapcfg=1"]
karg-deletes = ["gapdel=1"]
podman build -t localhost/gaprepro:1 .
truncate -s 20G a.raw b.raw
podman run --rm --privileged --pid=host --security-opt label=type:unconfined_t \
  -v /dev:/dev -v /var/lib/containers:/var/lib/containers -v $PWD:/out localhost/gaprepro:1 \
  bootc install to-disk --via-loopback --filesystem ext4 --generic-image --wipe \
  --composefs-backend --karg-delete=gapclidel=1 /out/a.raw
# the same again without --composefs-backend, writing b.raw

/proc/cmdline after booting each disk, from rw onwards:

composefs: rw composefs=52e75610b743... gapdel=1 gapclidel=1
ostree:    rw gapcfg=1 ostree=/ostree/boot.1/default/2e3c2da7.../0

The ostree path adds the install config kargs and kargs.d, then applies karg-deletes and --karg-delete, in install_container (install.rs L1217-L1252). The composefs BLS entry takes root_setup.kargs and --karg (boot.rs L782-L791) and adds kargs.d through compute_new_kargs (L865), and nothing under bootc_composefs reads install_config or karg_delete. plan-40-install-karg-delete is skipped on composefs (integration.fmf L252-L258).

#2304 and #2305 covered --karg on this path; these are the remaining kernel argument options. I'd expect composefs installs to apply them as ostree installs do, or to reject them. I only tested to-disk with BLS entries.

Lingua principale
Rust
Stelle
2.3k
Fork
230
Merge medio
2g 11h
PR unite (30g)
42

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di bootc-dev/bootc

Tutte le issue di bootc-dev/bootc

Issue simili

Altre issue su Rust

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.