install: --composefs-backend ignores install config kargs, karg-deletes and --karg-delete

Ouverte
#2,539 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub

Les mainteneurs répondent en général sous 2 jours

Personne n'a encore pris cette issue.

  • #42 par @cgwalters-bot — fermée sans fusion

Évaluation

Difficulté
3/5
Temps estimé
1-2 jours
Accessibilité débutants
68/100
Type d'issue
Bug
Clarté
Clairement spécifiée
Activité
Active
Stack technique
rust

Piste de recherche

Start with install_container in crates/lib/src/install.rs and the composefs BLS-entry and compute_new_kargs paths in crates/lib/src/bootc_composefs/boot.rs. Read the plan-40-install-karg-delete skip in tmt/plans/integration.fmf and the related tests; reproduce the to-disk case described here. Done means composefs applies install-config kargs and both delete sources like the ostree path, or clearly rejects unsupported options.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

With --composefs-backend, bootc install to-disk ignores kargs and karg-deletes from the install config, and the --karg-delete option. The config kargs are missing from the kernel command line, and the deletes leave their kargs in place. The install exits 0 without a warning. The same install without --composefs-backend applies all three.

Reproduced on quay.io/fedora/fedora-bootc:44 (bootc 1.16.13) with this derived image:

FROM quay.io/fedora/fedora-bootc:44@sha256:5ab8ee5189bb0f3870279723f5343474df002d8d6f46564702b3ad3ba7382d98
COPY 10-gapbase.toml /usr/lib/bootc/kargs.d/10-gapbase.toml
COPY 50-gaps.toml /usr/lib/bootc/install/50-gaps.toml
# 10-gapbase.toml
kargs = ["gapdel=1", "gapclidel=1"]

# 50-gaps.toml
[install]
kargs = ["gapcfg=1"]
karg-deletes = ["gapdel=1"]
podman build -t localhost/gaprepro:1 .
truncate -s 20G a.raw b.raw
podman run --rm --privileged --pid=host --security-opt label=type:unconfined_t \
  -v /dev:/dev -v /var/lib/containers:/var/lib/containers -v $PWD:/out localhost/gaprepro:1 \
  bootc install to-disk --via-loopback --filesystem ext4 --generic-image --wipe \
  --composefs-backend --karg-delete=gapclidel=1 /out/a.raw
# the same again without --composefs-backend, writing b.raw

/proc/cmdline after booting each disk, from rw onwards:

composefs: rw composefs=52e75610b743... gapdel=1 gapclidel=1
ostree:    rw gapcfg=1 ostree=/ostree/boot.1/default/2e3c2da7.../0

The ostree path adds the install config kargs and kargs.d, then applies karg-deletes and --karg-delete, in install_container (install.rs L1217-L1252). The composefs BLS entry takes root_setup.kargs and --karg (boot.rs L782-L791) and adds kargs.d through compute_new_kargs (L865), and nothing under bootc_composefs reads install_config or karg_delete. plan-40-install-karg-delete is skipped on composefs (integration.fmf L252-L258).

#2304 and #2305 covered --karg on this path; these are the remaining kernel argument options. I'd expect composefs installs to apply them as ostree installs do, or to reject them. I only tested to-disk with BLS entries.

Langage dominant
Rust
Étoiles
2.3k
Forks
230
Merge moyen
2 j 11 h
PR mergées (30 j)
42

Préparer son environnement

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de bootc-dev/bootc

Toutes les issues de bootc-dev/bootc

Issues similaires

Plus d'issues Rust

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.