Pool amplicon libraries allows for 0 concentration triggering an exception
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 42/100
Research direction
Start with the pooling form handler in labcontrol/gui/handlers/process_handlers/pooling_process.py and trace the request into labcontrol/db/process.py around line 2406, where input_volume is compared with 0.001. Reproduce the down-arrow input and inspect how the concentration becomes None. Done means the zero-concentration path no longer triggers the reported exception.
Written by the indexing model from the issue text.
Description
It's possible to select the down arrow when specifying a concentration. This results in the following exception:
AN ERROR HAS OCCURED!
Please copy the following into an issue in our github repository
Error
'<' not supported between instances of 'NoneType' and 'float'
Traceback
Traceback (most recent call last):
File "/Users/dtmcdonald/miniconda3/envs/labcontrol/lib/python3.7/site-packages/tornado/web.py", line 1697, in _execute result = method(*self.path_args, **self.path_kwargs)
File "/Users/dtmcdonald/miniconda3/envs/labcontrol/lib/python3.7/site-packages/tornado/web.py", line 3174, in wrapper return method(self, *args, **kwargs)
File "/Users/dtmcdonald/ResearchWork/software/labman/labcontrol/gui/handlers/process_handlers/pooling_process.py", line 310, in post {"function": "amplicon_pool", "parameters": {}})
File "/Users/dtmcdonald/ResearchWork/software/labman/labcontrol/db/process.py", line 2406, in create if in_comp['input_volume'] < 0.001:
TypeError: '<' not supported between instances of 'NoneType' and 'float'
- Dominant language
- Python
- Stars
- 2
- Forks
- 15
- PR merge metrics
- No merged PRs in 30d
Getting set up
We have not checked this project's setup files yet. Start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from biocore/LabControl
-
bug front-end question
Difficulty 4/5 3-5 days Newbie friendliness 30/100
biocore/LabControl#594 ·
-
front-end question
Difficulty 5/5 Over a week Newbie friendliness 35/100
biocore/LabControl#593 ·
-
Cache list of active samples when the active study is changed in the plating interfaceMay be free again @fedarko claimed this 2574 days ago, and no pull request is open. Openfront-end
biocore/LabControl#592 · 1 assignee ·
-
code refactor front-end
Difficulty 5/5 Over a week Newbie friendliness 25/100
biocore/LabControl#591 ·
-
priority:low
Difficulty 3/5 1-2 days Newbie friendliness 20/100
biocore/LabControl#590 ·
All issues in biocore/LabControl
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-2 days Newbie friendliness 70/100
-
FingerprintSplitter raises ZeroDivisionError when int(frac_train * len(dataset)) floors to zeroOpen
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
Maintainers usually reply within 7 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
lmstudio-ai/mlx-engine#376 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
pyiron/bagofholding#166 ·