In plating interface, valid sample IDs occasionally "flash" red before turning another color
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 30/100
- Issue type
- Bug
- Clarity
- Needs clarification
- Activity status
- Stale
- Tech stack
- javascript
- Domain
- frontend
Research direction
Start in the plating interface at PlateViewer.patchWell(), reading the calls to PlateViewer.updateUnknownsAndDuplicates() and that.grid.updateRow(); compare the history around #585 and the former modifyWell() path. Try to reproduce the intermittent red flash, then determine whether the update ordering causes it. Done means valid sample IDs no longer briefly appear red, with the behavior verified under the relevant update sequence.
Written by the indexing model from the issue text.
Description
I don't know why this is happening—I don't think it's an artifact of the changes made in #585, but I suppose that could be the case. I think this behavior has been observed before, so I figure we should document this here.
Since this occurs really inconsistently (not sure if this means anything, but I wasn't able to reproduce this after adding a single debug console.log() statement to the top of PlateViewer.modifyWell()), my guess is that this is some sort of race condition—perhaps between the calls to PlateViewer.updateUnknownsAndDuplicates() and to that.grid.updateRow() in PlateViewer.patchWell() (formerly in PlateViewer.modifyWell()).
If this proves to be a significant annoyance, I can spend some time trying to track this down. But given how hard this is to reproduce, I don't think it's that serious of a problem.
- Dominant language
- Python
- Stars
- 2
- Forks
- 15
- PR merge metrics
- No merged PRs in 30d
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from biocore/LabControl
-
front-end question
Difficulty 5/5 Over a week Newbie friendliness 35/100
biocore/LabControl#593 ·
-
Cache list of active samples when the active study is changed in the plating interfaceMay be free again @fedarko claimed this 2581 days ago, and no pull request is open. Openfront-end
biocore/LabControl#592 · 1 assignee ·
-
code refactor front-end
Difficulty 5/5 Over a week Newbie friendliness 25/100
biocore/LabControl#591 ·
-
priority:low
Difficulty 3/5 1-2 days Newbie friendliness 20/100
biocore/LabControl#590 ·
-
priority:low scope:small
Difficulty 2/5 1-3 hours Newbie friendliness 45/100
biocore/LabControl#589 · 2 comments ·
All issues in biocore/LabControl
Similar issues
-
docs pydanty:is-working
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
pydantic/pydantic-ai#9800 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
-
[Bug]: With --api-server-count > 1, gauges such as vllm:num_requests_running have no samples until the first requestPossibly taken @roy6n23 claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
vllm-project/vllm#59988 · 2 comments ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
pymc-devs/pymc-examples#897 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 91/100