Refactor updateUnknownsAndDuplicates to only check certain wells, making it more efficient
Nobody has claimed this yet.
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 25/100
- Issue type
- Refactor
- Clarity
- Needs clarification
- Activity status
- Stale
- Tech stack
- javascript
- Domain
- frontend, performance
Research direction
Start in labcontrol/gui/static/js/plateViewer.js at patchWell() and updateUnknownsAndDuplicates(), then read the linked PR #585 discussion for the performance context. Trace which wells each change can affect and define how the refactored check will identify them. Done means the function no longer brute-force checks unrelated wells while preserving unknown and duplicate detection.
Written by the indexing model from the issue text.
Description
Recapping this issue: I wrote the following comment in patchWell()—
https://github.com/biocore/LabControl/blob/10ef1ef11f677957f23dc9765235e5642a81e1e1/labcontrol/gui/static/js/plateViewer.js#L458-L472
@AmandaBirmingham responded to it here—
Probably.
updateUnknownsAndDuplicatesis completely agnostic to whatever change triggered it--but that means it has to be brute-force and re-check everything. I think it is the source of a lot of the performance issues in the platemapper, and probably needs to be rethought from the ground up. Could you add an issue to the repo for this, and then remove this comment?
- Dominant language
- Python
- Stars
- 2
- Forks
- 15
- PR merge metrics
- No merged PRs in 30d
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from biocore/LabControl
-
bug front-end question
Difficulty 4/5 3-5 days Newbie friendliness 30/100
biocore/LabControl#594 ·
-
front-end question
Difficulty 5/5 Over a week Newbie friendliness 35/100
biocore/LabControl#593 ·
-
front-end
biocore/LabControl#592 · 1 assignee ·
-
priority:low
Difficulty 3/5 1-2 days Newbie friendliness 20/100
biocore/LabControl#590 ·
-
priority:low scope:small
Difficulty 2/5 1-3 hours Newbie friendliness 45/100
biocore/LabControl#589 · 2 comments ·
All issues in biocore/LabControl
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
syfoud/Simulated_Scepter#172 ·
-
A cancelled tests run makes the coverage comment workflow fail and reports it as a red check on main Openarea: ci bug perceived difficulty: 3
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Nitjsefnie-Harness-Commons/daedalus#921 · 1 comment ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
EleutherAI/lm-evaluation-harness#4207 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 92/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
ClickHouse/clickhouse-connect#1057 ·