Feature Request: Time Tracking Permissions

Open
#342 1 comment 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
5/5
Estimated time
Over a week
Newbie friendliness
22/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Active
Domain
authorization

Research direction

The request is about restricting what users see in the Time & Projects feature, including organization details, projects, and customers in time reports. Start by reading issue #300, which the author says covers workspace permissions, and check how the existing permission checks are applied on the server. Before any code, the maintainers need to choose between Option 1 (a system-level permission for the whole feature) and Option 2 (per-user visibility of assigned organizations). Done means the chosen option is agreed and server-side checks block the data, not only the UI.

Written by the indexing model from the issue text.

Description

Issue

When you add a user, regardless of their permissions, they can see all configuration in the time tracking time and projects feature. This has the potential to leak sensitive information (such as the hourly rate) when using Windshift as a tenanted system with multiple clients accessing the admin to view work status. I know that https://github.com/Windshiftapp/core/issues/300 resolves the issues around permissions for workspaces, however that Is not the only place that sensitive information could be viewed.

Current Behaviour

  • Every user can see see all organization details and all projects
  • Every user can see all customers in the time tracking reports

Desired Behaviour

The ability to secure the sensitive information in the Time & Projects feature whether that be through feature restrictions or sub-feature permissions.

Option 1:
  • Add in general system permissions to restrict access and visibility to Time & Projects to even see it
  • Access permissions should be validated server-side to ensure data isn't leaked
Option 2:
  • Add in sub feature permissions to only allowed users see assigned organizations
  • Access permissions should be validated server-side to ensure data isn't leaked

Benefits:

This would help make it so that you can invite clients to collaborate on a workspace, but restrict details in the rest of the application that may leak information about other clients and projects and would enhance other permission controls. Option 1 seems like it would be the easiest to implement, as not ever user needs to log or review time, and would make the tool more friendly to direct client collaboration on a workspace.

Dominant language
Go
Stars
421
Forks
50
Avg merge
17h 34m
Merged PRs (30d)
80

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from Windshiftapp/core

All issues in Windshiftapp/core

Similar issues

More Go issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.