Desktop app invites use the wrong link in Copy.
Maintainers usually reply within 1 day
A pull request for this has already been merged.
- #1731 by @SkyJoshua — merged
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 65/100
Research direction
The payload names no file, so begin with the invite Copy action in the UI and find where it builds the link from the current page URL. Reproduce it in the desktop build to confirm the output is app://localhost/I/. Done when Copy yields the public valour.gg/I/ link in the desktop app and the web client behaves as before.
Written by the indexing model from the issue text.
Description
Describe the bug
Invites on the desktop app copy as app://localhost/I/ instead of the correct remote link.
Looking at the code, this seems to be an issue with the fact the UI is served locally, and the copy uses the url of the UI to create the invite link.
To Reproduce
Steps to reproduce the behavior:
- Go to 'invites'
- Click on 'copy'
Expected behavior
An invite from valour.gg/I/
System Information:
- OS: Linux Desktop
- Valour Version: 0.9.12
- Valour Platform: Flatpak
Additional context
Add any other context about the problem here.
None
- Dominant language
- C#
- Stars
- 411
- Forks
- 41
- Avg merge
- 5d 4h
- Merged PRs (30d)
- 13
Getting set up
- Ships a Dockerfile or Docker Compose file
- No pull request template
- No contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from Valour-Software/Valour
-
Needs Looking At
Difficulty 1/5 Under an hour Newbie friendliness 85/100
Valour-Software/Valour#1735 ·
Maintainers usually reply within 1 day
-
Good First Issue Needs Looking At
Difficulty 2/5 1-3 hours Newbie friendliness 64/100
Valour-Software/Valour#1724 ·
Maintainers usually reply within 1 day
-
Needs Looking At
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Valour-Software/Valour#1719 ·
Maintainers usually reply within 1 day
-
Needs Looking At
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Valour-Software/Valour#1718 · 1 comment ·
Maintainers usually reply within 1 day
-
Needs Looking At
Difficulty 3/5 1-2 days Newbie friendliness 45/100
Valour-Software/Valour#1738 ·
Maintainers usually reply within 1 day
All issues in Valour-Software/Valour
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Facepunch/sbox-public#12305 ·
Maintainers usually reply within 5 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
JiaFeiMiao-K-Cat/DiscImageStudio#205 ·
Maintainers usually reply within 1 day
-
bug keep-fresh
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Flow-Launcher/Flow.Launcher#4744 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
flyingpie/windows-terminal-quake#419 ·
Maintainers usually reply within 1 day
-
enhancement help wanted
Difficulty 2/5 1-3 hours Newbie friendliness 82/100