BUG: Disabling a web searches source doesn't disable its keyword

Open Beginner friendly
  • Is something wrong?
#4,744 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
68/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
csharp
Domain
desktop, search

Research direction

Trace how Flow Launcher loads web search sources and registers their keywords, then compare that path with the settings logic for disabling a source. Start by locating the web searches settings and the plugin indicator code; the issue names no files or tests. Done means a disabled source’s keyword no longer triggers and no longer appears in the plugin indicator, while enabled sources still work.

Written by the indexing model from the issue text.

Description

bug keep-fresh
Checks

  • I have checked that this issue has not already been reported.

  • I am using the latest version of Flow Launcher.

  • I am using the prerelease version of Flow Launcher.

Problem Description

Even if you go to the settings and disable a search source it's keyword can still be triggered, it just shows no results
As well as that it also shows up in the plugin indicator's list which can be very annoying particularly as there is a large amount of sources that one might prefer to disable instead of outright delete (which does remove the keyword)

To Reproduce
  1. Disable search source in web searches settings, e.g. g for google
  2. search g in flow launcher
  3. keyword is triggered with no results
Screenshots

No response

Flow Launcher Version

2.1.4

Windows Build Number

10.0.26300.9818

Error Log

No response

Dominant language
C#
Stars
16k
Forks
673
Avg merge
2d 5h
Merged PRs (30d)
9

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from Flow-Launcher/Flow.Launcher

All issues in Flow-Launcher/Flow.Launcher

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.