EditIdentity audit log type shows no details

Open
  • Is something wrong?
#1,738 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
45/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
csharp
Domain
backend

Research direction

The payload names no file, so begin by searching the C# backend for where the EditIdentity audit entry is written, then compare it with an audit action that does record details. Check which values are captured before and after an identity edit, such as picture and nickname. Done when a moderator's identity edit produces an audit entry that lists the changed fields, verified by an audit log test or a manual edit.

Written by the indexing model from the issue text.

Description

Needs Looking At

Describe the bug
Audit logs for the EditIdentity action show blank details and are vague when admins need to know what specific details on a member's planet identity were changed. This poses a large gap in situations where planet moderators abuse the planet identity permissions.

To Reproduce
Steps to reproduce the behavior:

  1. Edit another member's planet identity using moderator permissions
  2. Check audit logs
  3. Look for the action labeled EditIdentity
  4. Notice there are no details attached to the log

Expected behavior
EditIdentity logs should give specific details on what was changed, like picture, nickname, etc.

Screenshots

Image Image

System Information:
N/A

Additional context
Sorry Josh - you're not in trouble 🫶

Dominant language
C#
Stars
411
Forks
41
Avg merge
5d 4h
Merged PRs (30d)
13

Getting set up

  • Ships a Dockerfile or Docker Compose file
  • No pull request template
  • No contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from Valour-Software/Valour

All issues in Valour-Software/Valour

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.