2FA modal does not block email and password controls and is not in focus

Open Beginner friendly
#1,724 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 3 days

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
64/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
csharp

Research direction

Start at the login flow that displays the 2FA modal and inspect how focus and the email and password controls behave while it is open. Reproduce by logging in with 2FA enabled and typing without clicking the input; done when the 2FA field captures input and the other fields cannot be edited during verification.

Written by the indexing model from the issue text.

Description

Good First Issue Needs Looking At

Describe the bug
If the user logs into account that has 2FA enabled, the 2FA input field is not capturing input making them to manually click into the input field.

To Reproduce
Steps to reproduce the behavior:

  1. Log out if you are logged on (check if you have 2FA enabled prior to this)
  2. Enter your credentials as usual, click Login
  3. Not touching the mouse (or tapping the screen) try to input some numbers—they will go into the last focused field (in my case, the password)

Expected behavior
Email and password fields are locked from editing

System Information:

  • OS: Any
  • Valour Version: 0.9.19 (efa5fc5)
  • Valour Platform: Any
    • Browser: Any
Dominant language
C#
Stars
411
Forks
41
Avg merge
4d 18h
Merged PRs (30d)
8

Getting set up

  • Ships a Dockerfile or Docker Compose file
  • No pull request template
  • No contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from Valour-Software/Valour

All issues in Valour-Software/Valour

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.