Is there a missing #include <d3d11.h> in IUnityGraphicsD3D11.h ?
Nobody has claimed this yet.
Assessment
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Newbie friendliness
- 55/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Stale
- Tech stack
- cpp
- Domain
- computer-graphics
Research direction
Open IUnityGraphicsD3D11.h and check whether its declarations require types from d3d11.h before that header is included. Reproduce the reported header-order failure with d3d11.h included afterward; done means the header works in that order without unknown type errors.
Written by the indexing model from the issue text.
Description
I wasn't sure if this was intentional or if I'm missing something but, I just had my code break when an autoformatter sorted my headers, which made my #include <d3d11.h> get declared after IUnityGraphicsD3D11.h, leading to lots of unknown type errors
- Dominant language
- C
- Stars
- 946
- Forks
- 186
- PR merge metrics
- No merged PRs in 30d
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from Unity-Technologies/NativeRenderingPlugin
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
-
Difficulty 4/5 3-5 days Newbie friendliness 25/100
Unity-Technologies/NativeRenderingPlugin#46 · 1 comment ·
-
Difficulty 4/5 3-5 days Newbie friendliness 30/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 50/100
Unity-Technologies/NativeRenderingPlugin#42 · 2 comments ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 25/100
All issues in Unity-Technologies/NativeRenderingPlugin
Similar issues
-
Discover carries headerEdges that nothing reads since #1914 moved E0507/E0517 to the compiler graphOpentech-debt
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
Maintainers usually reply within 1 day
-
2个显示的问题Open
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
coolsnowwolf/lede#14209 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 75/100
polhenarejos/pico-hsm#147 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 85/100
OpenPrinting/cups#1746 ·
Maintainers usually reply within 1 day
-
Status: Opened
Difficulty 1/5 Under an hour Newbie friendliness 75/100
Maintainers usually reply within 1 day