Italic tags should not include roman characters attached to an italic word (dialogue dash, elided article, trailing punctuation)

Open
  • Is something wrong?
#16,367 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
48/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
csharp
Domain
desktop

Research direction

Start by inspecting the Blu-ray SUP OCR path that produces italic tags and compare its output with the attached sample, especially the dialogue dash, elided words, and final punctuation. The report does not name the relevant files or tests; trace where OCR styling is assigned and check whether roman characters can be kept outside the tags. Done means the sample output leaves those roman characters unitalicized.

Written by the indexing model from the issue text.

Description

Version: Subtitle Edit 5.4.0 Beta 5 (Windows)

Description
When OCR-ing a Blu-ray SUP, characters that are roman in the image end up inside the <i> tags when they touch an italic word: the dialogue dash, elided articles/prepositions (l', d', qu'…) and final punctuation. In French typography they stay roman, e.g. a ship name in italics:

- On manque de marins sur l'<i>Artemis</i>.

Instead, the OCR output puts these characters in italics in the subtitle itself (see screenshot), so they are saved in italics in the file.

Image

Sample
I attached a sample SUP that reproduces the issue.

sample.zip

Request
Could the OCR keep these characters outside the <i> tags when they are roman in the image? Alternatively, an option or a "Fix common errors" rule ("Keep dialogue dashes, elided articles and trailing punctuation in roman") would help a lot.

Dominant language
C#
Stars
14.8k
Forks
1.4k
Avg merge
57m
Merged PRs (30d)
637

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from SubtitleEdit/subtitleedit

All issues in SubtitleEdit/subtitleedit

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.