Packages that use the same template name change each other's widgets

Open
#805 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
54/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
macos, swift
Domain
backend

Research direction

Start with preparePackageDocument in Sources/StableBar/WidgetPackage.swift and expandWidgetTemplate in Sources/StableBar/ConfigurationLoader.swift; trace how package templates are composed and selected for package widgets. Read docs/packages.md to understand the supported root-level customization. Done when widgets use their own package templates while same-named root templates can still customize them; reproduce with two packages both defining Player.

Written by the indexing model from the issue text.

Description

bug

What happens

Templates from every enabled package and from your own files share one set of names, and templates with the same name merge recursively, later ones winning. When two packages define a template with the same name, the widgets of both draw the merged template, so each package can change the other's widgets.

This matters now that packages pick a template from a setting. Now playing 1.3.0 (stablebar-packages#55) chooses its bar look with "template": "@setting.barLook", so its templates are named after the choices Settings shows, Compact and Player. Any other package with a Player template changes Now playing's bar, and Now playing changes that package's widgets.

Steps to reproduce

  1. Enable Now playing from stablebar-packages#55 with Bar look set to Player.

  2. Enable a second package, such as this widgets package:

    {
      "widgets": [{ "id": "other-clock", "type": "clock", "format": "HH:mm", "position": "right", "template": "Player" }],
      "templates": { "Player": { "layout": { "type": "row", "children": [{ "type": "text", "text": "OTHER PACKAGE LAYOUT" }] } } }
    }
    

Expected

Each package's widgets use that package's own templates. A template in your own configuration can still customize a package's template on purpose, as Packages documents ("Root templates, tokens and widget overrides can customize them").

Environment

main at 36c9f858 (0.18.0-beta.20261118065952.1353), drawn offscreen with --render-scenes, macOS 27.

Evidence

Now playing alone:

With the second package, Now playing draws the other package's text, still with its own progress line and 284 pt width, and the other package's clock takes Now playing's width and padding:

Diagnosis

preparePackageDocument in Sources/StableBar/WidgetPackage.swift keeps a package's template names as written. The loader composes every layer into one templates object, merging same-named templates recursively, and expandWidgetTemplate in Sources/StableBar/ConfigurationLoader.swift looks a widget's template up in that merged object. Commands keep their own package's folder: each package widget's own environment.PACKAGE_DIR overrides the template's, so a clash changes layout and style, not where scripts run.

A possible fix: resolve a package widget's template against its own package's templates, then apply a same-named template from your own configuration on top, so the documented customization keeps working and packages no longer reach each other's. Package authors can avoid a clash today with distinctive names, but a name that's also a setting choice shows in Settings exactly as written.

Related

  • #601 and #603 (closed, not planned): titles for setting choices in package.json, declined because older builds reject the manifest. Titles would have let a package use scoped template names with readable choices.
  • #602: settings in manifest order with labels.
  • stablebar-packages#55: Now playing's Bar look setting.

Triaged by Claude Code (Claude Opus 5.5).

Dominant language
Swift
Stars
184
Forks
12
Avg merge
3h 50m
Merged PRs (30d)
387

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from Seb-GRAF/StableBar

All issues in Seb-GRAF/StableBar

Similar issues

More Swift issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.