Packages that use the same template name change each other's widgets

オープン
#805 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

まだ誰も着手していません。

評価

難易度
4/5
見積もり時間
3〜5日
初心者へのやさしさ
54/100
issue の種類
バグ
明瞭さ
明確に書かれている
活発さ
活発
技術スタック
macos, swift
領域
backend

調査の方向性

Start with preparePackageDocument in Sources/StableBar/WidgetPackage.swift and expandWidgetTemplate in Sources/StableBar/ConfigurationLoader.swift; trace how package templates are composed and selected for package widgets. Read docs/packages.md to understand the supported root-level customization. Done when widgets use their own package templates while same-named root templates can still customize them; reproduce with two packages both defining Player.

索引モデルが issue の本文から書いたものです。

説明

bug

What happens

Templates from every enabled package and from your own files share one set of names, and templates with the same name merge recursively, later ones winning. When two packages define a template with the same name, the widgets of both draw the merged template, so each package can change the other's widgets.

This matters now that packages pick a template from a setting. Now playing 1.3.0 (stablebar-packages#55) chooses its bar look with "template": "@setting.barLook", so its templates are named after the choices Settings shows, Compact and Player. Any other package with a Player template changes Now playing's bar, and Now playing changes that package's widgets.

Steps to reproduce

  1. Enable Now playing from stablebar-packages#55 with Bar look set to Player.

  2. Enable a second package, such as this widgets package:

    {
      "widgets": [{ "id": "other-clock", "type": "clock", "format": "HH:mm", "position": "right", "template": "Player" }],
      "templates": { "Player": { "layout": { "type": "row", "children": [{ "type": "text", "text": "OTHER PACKAGE LAYOUT" }] } } }
    }
    

Expected

Each package's widgets use that package's own templates. A template in your own configuration can still customize a package's template on purpose, as Packages documents ("Root templates, tokens and widget overrides can customize them").

Environment

main at 36c9f858 (0.18.0-beta.20261118065952.1353), drawn offscreen with --render-scenes, macOS 27.

Evidence

Now playing alone:

With the second package, Now playing draws the other package's text, still with its own progress line and 284 pt width, and the other package's clock takes Now playing's width and padding:

Diagnosis

preparePackageDocument in Sources/StableBar/WidgetPackage.swift keeps a package's template names as written. The loader composes every layer into one templates object, merging same-named templates recursively, and expandWidgetTemplate in Sources/StableBar/ConfigurationLoader.swift looks a widget's template up in that merged object. Commands keep their own package's folder: each package widget's own environment.PACKAGE_DIR overrides the template's, so a clash changes layout and style, not where scripts run.

A possible fix: resolve a package widget's template against its own package's templates, then apply a same-named template from your own configuration on top, so the documented customization keeps working and packages no longer reach each other's. Package authors can avoid a clash today with distinctive names, but a name that's also a setting choice shows in Settings exactly as written.

Related

  • #601 and #603 (closed, not planned): titles for setting choices in package.json, declined because older builds reject the manifest. Titles would have let a package use scoped template names with readable choices.
  • #602: settings in manifest order with labels.
  • stablebar-packages#55: Now playing's Bar look setting.

Triaged by Claude Code (Claude Opus 5.5).

主要言語
Swift
スター
184
フォーク
12
平均マージ
3時間 50分
マージ済み PR(30日)
387

環境構築

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

Seb-GRAF/StableBar のほかの issue

Seb-GRAF/StableBar の issue をすべて見る

似ている issue

Swift の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。