Packages that use the same template name change each other's widgets
Los mantenedores suelen responder en 1 día
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 4/5
- Tiempo estimado
- 3-5 días
- Aptitud para principiantes
- 54/100
Línea de trabajo
Start with preparePackageDocument in Sources/StableBar/WidgetPackage.swift and expandWidgetTemplate in Sources/StableBar/ConfigurationLoader.swift; trace how package templates are composed and selected for package widgets. Read docs/packages.md to understand the supported root-level customization. Done when widgets use their own package templates while same-named root templates can still customize them; reproduce with two packages both defining Player.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
What happens
Templates from every enabled package and from your own files share one set of names, and templates with the same name merge recursively, later ones winning. When two packages define a template with the same name, the widgets of both draw the merged template, so each package can change the other's widgets.
This matters now that packages pick a template from a setting. Now playing 1.3.0 (stablebar-packages#55) chooses its bar look with "template": "@setting.barLook", so its templates are named after the choices Settings shows, Compact and Player. Any other package with a Player template changes Now playing's bar, and Now playing changes that package's widgets.
Steps to reproduce
-
Enable Now playing from stablebar-packages#55 with Bar look set to Player.
-
Enable a second package, such as this widgets package:
{ "widgets": [{ "id": "other-clock", "type": "clock", "format": "HH:mm", "position": "right", "template": "Player" }], "templates": { "Player": { "layout": { "type": "row", "children": [{ "type": "text", "text": "OTHER PACKAGE LAYOUT" }] } } } }
Expected
Each package's widgets use that package's own templates. A template in your own configuration can still customize a package's template on purpose, as Packages documents ("Root templates, tokens and widget overrides can customize them").
Environment
main at 36c9f858 (0.18.0-beta.20261118065952.1353), drawn offscreen with --render-scenes, macOS 27.
Evidence
Now playing alone:
With the second package, Now playing draws the other package's text, still with its own progress line and 284 pt width, and the other package's clock takes Now playing's width and padding:
Diagnosis
preparePackageDocument in Sources/StableBar/WidgetPackage.swift keeps a package's template names as written. The loader composes every layer into one templates object, merging same-named templates recursively, and expandWidgetTemplate in Sources/StableBar/ConfigurationLoader.swift looks a widget's template up in that merged object. Commands keep their own package's folder: each package widget's own environment.PACKAGE_DIR overrides the template's, so a clash changes layout and style, not where scripts run.
A possible fix: resolve a package widget's template against its own package's templates, then apply a same-named template from your own configuration on top, so the documented customization keeps working and packages no longer reach each other's. Package authors can avoid a clash today with distinctive names, but a name that's also a setting choice shows in Settings exactly as written.
Related
- #601 and #603 (closed, not planned): titles for setting choices in
package.json, declined because older builds reject the manifest. Titles would have let a package use scoped template names with readable choices. - #602: settings in manifest order with labels.
- stablebar-packages#55: Now playing's Bar look setting.
Triaged by Claude Code (Claude Opus 5.5).
- Lenguaje dominante
- Swift
- Estrellas
- 184
- Forks
- 12
- Merge medio
- 3 h 50 min
- PR fusionados (30 d)
- 387
Preparar el entorno
- Sin Dockerfile ni archivo de Docker Compose
- Tiene una plantilla de pull request
- Leer la guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de Seb-GRAF/StableBar
-
enhancement
Dificultad 2/5 1-3 horas Aptitud para principiantes 82/100
Los mantenedores suelen responder en 1 día
-
enhancement
Dificultad 4/5 3-5 días Aptitud para principiantes 52/100
Los mantenedores suelen responder en 1 día
-
Menu bar items drawn as in the menu bar show the wrong part of the menu bar after a display changePosiblemente ocupada @Jonathanm10 la tomó hoy. Abiertoneeds-triage
Dificultad 2/5 1-3 horas Aptitud para principiantes 35/100
Los mantenedores suelen responder en 1 día
-
enhancement
Dificultad 5/5 Más de una semana Aptitud para principiantes 30/100
Los mantenedores suelen responder en 1 día
-
Allow the App Menu to display the frontmost app iconPosiblemente ocupada @khatami10 la tomó hoy. Abiertoenhancement needs-triage
Dificultad 3/5 1-2 días Aptitud para principiantes 35/100
Los mantenedores suelen responder en 1 día
Todos los issues de Seb-GRAF/StableBar
Issues similares
-
documentation ui
Dificultad 2/5 1-3 horas Aptitud para principiantes 78/100
aydenjahola/Hush#41 ·
Los mantenedores suelen responder en 1 día
-
good first issue help wanted testing
Dificultad 1/5 Menos de una hora Aptitud para principiantes 78/100
-
area:cli documentation good first issue priority:low
Dificultad 1/5 Menos de una hora Aptitud para principiantes 94/100
isaaclins/freesnitch#430 ·
Los mantenedores suelen responder en 1 día
-
bug
Dificultad 2/5 1-3 horas Aptitud para principiantes 82/100
MasterJ93/ATProtoKit#354 ·
-
enhancement help wanted
Dificultad 2/5 1-3 horas Aptitud para principiantes 84/100
heysidhant/appvanish#4 ·