Flaky test_a_uniform_change_shows_in_every_decile at half-penny shifts
Maintainers usually reply within 2 days
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 72/100
Research direction
Start with test_a_uniform_change_shows_in_every_decile and the aggregate-impact decile tests introduced in #2335. Run the failing case with seed=0, shift=0.005 and trace how the strategy selects shifts versus the half-penny comparison threshold. Done when shifts at or below the threshold are excluded or assertions cover only larger shifts, with the threshold unchanged.
Written by the indexing model from the issue text.
Description
test_a_uniform_change_shows_in_every_decile (the aggregate-impact decile tests, from #2335) is flaky. It fails at seed=0, shift=0.005.
- Why: the comparison treats a change of half a penny or less as no change, so a uniform shift that small doesn't "show in every decile", as the test expects.
- Effect: the test can fail CI at random on any PR.
- Fix: have the strategy exclude shifts at or below the half-penny threshold, or assert on shifts above it only. Don't change the threshold.
- Found by: the hub's independent review of #2425 (10/19).
- Dominant language
- Python
- Stars
- 51
- Forks
- 34
- Avg merge
- 2d 23h
- Merged PRs (30d)
- 239
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from PolicyEngine/policyengine-uk
-
Northern Ireland business rates statistic is twice the OBR NI line: regional vs district ratesPossibly taken A pull request linked to this issue is open or already merged. Open
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
PolicyEngine/policyengine-uk#2343 ·
Maintainers usually reply within 2 days
-
Follow-ups from #2160: qualifying-age docstring, UC work-related groups property-file speed, changelog fragment examplePossibly taken @juaristi22 claimed this 4 days ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
PolicyEngine/policyengine-uk#2162 ·
Maintainers usually reply within 2 days
-
Scottish Carer Supplement rate has no upratingPossibly taken @MaxGhenis claimed this 18 days ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
PolicyEngine/policyengine-uk#1957 ·
Maintainers usually reply within 2 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
PolicyEngine/policyengine-uk#1740 ·
Maintainers usually reply within 2 days
-
Difficulty 1/5 Under an hour Newbie friendliness 62/100
PolicyEngine/policyengine-uk#614 · 1 comment ·
Maintainers usually reply within 2 days
All issues in PolicyEngine/policyengine-uk
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
zach-blumenfeld/aip#13 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 80/100
nathanmarlor/foxess_modbus#1287 ·
Maintainers usually reply within 4 days
-
bug good first issue help wanted
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
OpenLakeForge/openlakeforge#498 ·
Maintainers usually reply within 1 day
-
good first issue hacktoberfest help wanted python
Difficulty 2/5 1-3 hours Newbie friendliness 73/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 69/100
pollen-robotics/reachy_mini#1493 ·
Maintainers usually reply within 1 day