Polish fractional-cent display and invalid expense navigation

Open
#57 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 2 days

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
45/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
javascript
Domain
frontend

Research direction

Start by reading the monthly expense fix and the second review of #52, then trace the wizard’s monetary inputs and unit switching. Check how annual amounts below one cent per month, pasted fractional-cent values, and invalid entries behave; preserve underlying values and shared links. Done means those display and validation choices are consistent and the existing typing and invalid-rent regressions still pass.

Written by the indexing model from the issue text.

Description

The monthly expense fix preserves partial decimals while typing and annual values on submission. Three optional input details from the second review of #52 remain:

  • Consider a consistent display for a positive annual amount whose monthly equivalent rounds below one cent. Preserve the underlying amount.
  • Decide whether wages, other income and assets should display more than two decimal places when a pasted value contains fractional cents. Preserve existing shared links.
  • If someone leaves a wizard step with an invalid monetary entry, consider showing the native validation message first. The current form keeps the last valid amount.

Chromium, Firefox and WebKit each passed the yearly and monthly typing checks. Chromium also submitted a focused monthly field containing 12.345 with Enter and produced 148.14 annually. The invalid-rent regression covers switching units and then correcting the amount.

Dominant language
JavaScript
Stars
0
Forks
0
Avg merge
1d 14h
Merged PRs (30d)
10

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from PolicyEngine/cliff-watch

All issues in PolicyEngine/cliff-watch

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.