Strengthen direct-host redirect regression tests
Maintainers usually reply within 2 days
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 68/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- javascript, next.js
Research direction
Start with the direct-host redirect regression test and its current import from Next.js's compiled dependencies. Add a case for a nested path with two query parameters, including an encoded space, and use the public entry point from the declared @vercel/routing-utils development dependency. The tests should verify that both values survive the redirect; the issue also points to #43 and the site-wide audit for related behavior.
Written by the indexing model from the issue text.
Description
The independent review of #51 confirmed that direct visits redirect to the canonical site with the path and query intact. Two changes would make the local tests more durable.
- Add a regression case for a nested path with two query parameters, including an encoded space. It should fail if a change to the redirect destination drops or rewrites either value.
- Declare
@vercel/routing-utilsas a development dependency and import its public entry point in the test. The current import reaches into Next.js's private compiled dependencies.
Three other review notes describe intended behavior. Issue #43 specifies that bare /api redirects while /api/* functions remain on the compute host. The two additional Vercel aliases the reviewer identified currently require Vercel sign-in. The explicit root rule preserves the slashless canonical URL, which the existing root test checks.
The site-wide audit already checks production root and nested redirects with a query parameter.
- Dominant language
- JavaScript
- Stars
- 0
- Forks
- 0
- Avg merge
- 1d 14h
- Merged PRs (30d)
- 10
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from PolicyEngine/cliff-watch
-
Difficulty 3/5 1-2 days Newbie friendliness 67/100
PolicyEngine/cliff-watch#59 · 1 comment ·
Maintainers usually reply within 2 days
-
Difficulty 4/5 3-5 days Newbie friendliness 48/100
PolicyEngine/cliff-watch#58 · 1 comment ·
Maintainers usually reply within 2 days
-
Difficulty 4/5 3-5 days Newbie friendliness 45/100
PolicyEngine/cliff-watch#57 ·
Maintainers usually reply within 2 days
-
Difficulty 4/5 3-5 days Newbie friendliness 45/100
PolicyEngine/cliff-watch#56 · 1 comment ·
Maintainers usually reply within 2 days
-
Difficulty 3/5 1-2 days Newbie friendliness 25/100
PolicyEngine/cliff-watch#33 ·
Maintainers usually reply within 2 days
All issues in PolicyEngine/cliff-watch
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 73/100
product-os/flowzone#2048 ·
Maintainers usually reply within 1 day
-
documentation
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
hugomrdias/playwright-test#786 · 1 comment ·
Maintainers usually reply within 1 day
-
code-review secondshift
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
piotrekno1/second-shift#419 ·
Maintainers usually reply within 1 day
-
area:compiler effort:S impact:low platform:wasm type:chore
Difficulty 1/5 Under an hour Newbie friendliness 85/100
Maintainers usually reply within 1 day
-
New style: solarpunkOpengood first issue new style
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
musicalbee/design-ontology#112 ·
Maintainers usually reply within 1 day