wasm/web: wasm_runtime.js declares __bitsToJsValue twice
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Newbie friendliness
- 85/100
- Issue type
- Refactor
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- javascript, rust, wasm
- Domain
- build-system, tooling
Research direction
Open crates/perry-codegen-wasm/src/wasm_runtime.js and compare the two __bitsToJsValue declarations at lines 3381 and 6280. Read the later declaration to confirm it is the live copy, then remove the earlier duplicate. Done means only one module-scope declaration remains; the issue does not name a test to run.
Written by the indexing model from the issue text.
Description
crates/perry-codegen-wasm/src/wasm_runtime.js has two function __bitsToJsValue declarations at module scope (lines 3381 and 6280 on main). Function declarations hoist, so only the later one is ever called and the earlier copy is dead code that can drift from the live one. Delete the dead copy.
Found while reviewing #15110, which fixed the BigInt mixing bug in the live copy (the same symptom #15104 reports for a patched builtin).
- Dominant language
- Rust
- Stars
- 4.9k
- Forks
- 166
- Avg merge
- 6h 5m
- Merged PRs (30d)
- 949
Getting set up
- Ships a Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from PerryTS/perry
-
area:stdlib effort:S impact:med platform:linux type:bug
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
Maintainers usually reply within 1 day
-
area:compiler effort:S impact:low platform:wasm type:bug
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
area:compiler effort:S impact:med platform:wasm type:bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
area:compiler effort:S impact:low platform:wasm type:chore
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
Similar issues
-
Difficulty 1/5 1-3 hours Newbie friendliness 76/100
416rehman/Guardrails#1716 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
dginev/latexml-oxide#943 ·
Maintainers usually reply within 1 day
-
bug ready
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
MartinPTielemans/ilo#3731 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
oetiker/shadcn-egui#50 ·
Maintainers usually reply within 2 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 83/100
vymalo/another-agentic-system#412 ·
Maintainers usually reply within 1 day