wasm/web: wasm_runtime.js declares __bitsToJsValue twice

Open Beginner friendly
#15,137 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
1/5
Estimated time
Under an hour
Newbie friendliness
85/100
Issue type
Refactor
Clarity
Clearly specified
Activity status
Active
Tech stack
javascript, rust, wasm

Research direction

Open crates/perry-codegen-wasm/src/wasm_runtime.js and compare the two __bitsToJsValue declarations at lines 3381 and 6280. Read the later declaration to confirm it is the live copy, then remove the earlier duplicate. Done means only one module-scope declaration remains; the issue does not name a test to run.

Written by the indexing model from the issue text.

Description

area:compiler effort:S impact:low platform:wasm type:chore

crates/perry-codegen-wasm/src/wasm_runtime.js has two function __bitsToJsValue declarations at module scope (lines 3381 and 6280 on main). Function declarations hoist, so only the later one is ever called and the earlier copy is dead code that can drift from the live one. Delete the dead copy.

Found while reviewing #15110, which fixed the BigInt mixing bug in the live copy (the same symptom #15104 reports for a patched builtin).

Dominant language
Rust
Stars
4.9k
Forks
166
Avg merge
6h 5m
Merged PRs (30d)
949

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from PerryTS/perry

All issues in PerryTS/perry

Similar issues

More Rust issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.