Clarify earnings interval bounds and cover grid edge cases
Maintainers usually reply within 2 days
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 45/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Active
- Tech stack
- javascript, python
- Domain
- backend-api-design, testing
Research direction
Start by reviewing the follow-up in PR #53 and tracing the Python interval handling, response metadata, and tests, then compare those rules with the test-only JavaScript axis builder and client regression tests. The issue does not name file paths, so locate those entry points from the repository. Done means the exact-bound and error cases, grid edge cases, metadata, and legacy 202-point rounding behavior are covered by tests.
Written by the indexing model from the issue text.
Description
The review of #53 found follow-up work on the earnings interval contract and its tests.
- Document how an explicit lower bound, including zero, requests an exact interval. Return a client error for reversed or empty bounds.
- Add a client regression for a cliff at the first earnings point and for sub-cent secondary wages. The client checks measured gaps. A browser with the old bundle can still report the requested step until it reloads.
- Align or retire the test-only JavaScript axis builder so its assertions exercise the current Python interval rules.
- Distinguish an adjusted grid from a truncated interval in response metadata. Keep the legacy full-range behavior explicit in the tests, including its 202-point rounding edge.
The exact intervals used by the current frontend already measure their maximum gap. The example catalog uses 201-point primary curves. Refinement fix
- Dominant language
- JavaScript
- Stars
- 0
- Forks
- 0
- Avg merge
- 1d 14h
- Merged PRs (30d)
- 10
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from PolicyEngine/cliff-watch
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
PolicyEngine/cliff-watch#55 ·
Maintainers usually reply within 2 days
-
Difficulty 3/5 1-2 days Newbie friendliness 67/100
PolicyEngine/cliff-watch#59 · 1 comment ·
Maintainers usually reply within 2 days
-
Difficulty 4/5 3-5 days Newbie friendliness 48/100
PolicyEngine/cliff-watch#58 · 1 comment ·
Maintainers usually reply within 2 days
-
Difficulty 4/5 3-5 days Newbie friendliness 45/100
PolicyEngine/cliff-watch#57 ·
Maintainers usually reply within 2 days
-
Difficulty 3/5 1-2 days Newbie friendliness 25/100
PolicyEngine/cliff-watch#33 ·
Maintainers usually reply within 2 days
All issues in PolicyEngine/cliff-watch
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 73/100
product-os/flowzone#2048 ·
Maintainers usually reply within 1 day
-
documentation
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
hugomrdias/playwright-test#786 · 1 comment ·
Maintainers usually reply within 1 day
-
code-review secondshift
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
piotrekno1/second-shift#419 ·
Maintainers usually reply within 1 day
-
area:compiler effort:S impact:low platform:wasm type:chore
Difficulty 1/5 Under an hour Newbie friendliness 85/100
Maintainers usually reply within 1 day
-
New style: solarpunkOpengood first issue new style
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
musicalbee/design-ontology#112 ·
Maintainers usually reply within 1 day