Hacktoberfest 2026: the issues maintainers tagged for October, open and beginner-friendly. Browse Hacktoberfest issues

Possible error in python import statement in README

Open
#247 1 comment 1 reaction 1 assignee View on GitHub

@chbroecker is already working on this.

Since Apr 2, 2026.

Assessment

This issue has not been assessed yet.

Description

After following the README instructions to setup the generate_parameter_library in python today, I continued to receive an ImportError. I looked into the generated parameter code and realized that my import was wrong and I believe there is an error in the README.

The top level key in the turtlesim_parameters.yaml is turtlesim while the import statement in the turtlesim/turtlesim.py file reads

from turtlesim_pkg.turtlesim_parameters import turtlesim_parameters

The last part of the import should be the top level key of the yaml file right? So only:

from turtlesim_pkg.turtlesim_parameters import turtlesim

I can create a PR that fixes this small error but I first wanted to make sure that I haven't missed anything obvious.

Also for completeness sake, the _pkg should also be removed if the file is called turtlesim/turtlesim.py right?

Dominant language
Python
Stars
385
Forks
81
PR merge metrics
No merged PRs in 30d

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from PickNikRobotics/generate_parameter_library

All issues in PickNikRobotics/generate_parameter_library

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.