wasm/web: direct table calls in wasm_runtime.js skip __padBigintArgs
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 72/100
Research direction
Start in crates/perry-codegen-wasm/src/wasm_runtime.js and review the direct fn(...) calls into the WASM function table, comparing them with the paths fixed in #15108 and #15110. Route remaining calls through __padBigintArgs; done when direct table calls pad arguments consistently and no longer trigger the reported BigInt type error for callees with higher declared arity.
Written by the indexing model from the issue text.
Description
Some direct fn(...) calls into the WASM function table in crates/perry-codegen-wasm/src/wasm_runtime.js pass their arguments without __padBigintArgs, unlike the paths #15108 and #15110 fixed. A callee whose declared arity exceeds the passed arguments then receives non-BigInt padding and can hit Cannot mix BigInt and other types. Audit the remaining direct table calls and route them through the shared padding helper.
Raised by CodeRabbit on #15108; pre-existing. Not the same as #15104, which is about __padBigintArgs itself reading a program-patched Math.max. Related: #15137.
- Dominant language
- Rust
- Stars
- 4.9k
- Forks
- 166
- Avg merge
- 6h 5m
- Merged PRs (30d)
- 949
Getting set up
- Ships a Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from PerryTS/perry
-
area:stdlib effort:S impact:med platform:linux type:bug
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
Maintainers usually reply within 1 day
-
area:compiler effort:S impact:low platform:wasm type:chore
Difficulty 1/5 Under an hour Newbie friendliness 85/100
Maintainers usually reply within 1 day
-
area:compiler effort:S impact:med platform:wasm type:bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
area:compiler effort:S impact:low platform:wasm type:chore
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
Similar issues
-
Difficulty 1/5 1-3 hours Newbie friendliness 76/100
416rehman/Guardrails#1716 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
dginev/latexml-oxide#943 ·
Maintainers usually reply within 1 day
-
bug ready
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
MartinPTielemans/ilo#3731 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
oetiker/shadcn-egui#50 ·
Maintainers usually reply within 2 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 83/100
vymalo/another-agentic-system#412 ·
Maintainers usually reply within 1 day