wasm/web: dead legacy `rt.array_join` and `rt.array_push_spread` imports in wasm_runtime.js
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 78/100
Research direction
Start in crates/perry-codegen-wasm/src/wasm_runtime.js and inspect the definitions of rt.array_join and rt.array_push_spread around line 359. Check that emitted code routes calls through mem_call to __memDispatch, then remove the unused imports. Done when both legacy definitions are gone and the live dispatch paths remain intact.
Written by the indexing model from the issue text.
Description
crates/perry-codegen-wasm/src/wasm_runtime.js still defines handle-based rt.array_join (around line 359, joins with JSON.stringify) and rt.array_push_spread. Emitted code never calls them: every call goes through mem_call to __memDispatch. Their semantics now differ from the live paths fixed in #15051 and #15055, so they should be deleted rather than left to drift.
- Dominant language
- Rust
- Stars
- 4.9k
- Forks
- 166
- Avg merge
- 6h 5m
- Merged PRs (30d)
- 949
Getting set up
- Ships a Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from PerryTS/perry
-
area:stdlib effort:S impact:med platform:linux type:bug
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
Maintainers usually reply within 1 day
-
area:compiler effort:S impact:low platform:wasm type:bug
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
area:compiler effort:S impact:low platform:wasm type:chore
Difficulty 1/5 Under an hour Newbie friendliness 85/100
Maintainers usually reply within 1 day
-
area:compiler effort:S impact:med platform:wasm type:bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
Similar issues
-
Difficulty 1/5 1-3 hours Newbie friendliness 76/100
416rehman/Guardrails#1716 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
dginev/latexml-oxide#943 ·
Maintainers usually reply within 1 day
-
bug ready
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
MartinPTielemans/ilo#3731 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
oetiker/shadcn-egui#50 ·
Maintainers usually reply within 2 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 83/100
vymalo/another-agentic-system#412 ·
Maintainers usually reply within 1 day