wasm/web: dead legacy `rt.array_join` and `rt.array_push_spread` imports in wasm_runtime.js

Open Beginner friendly
#15,115 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
78/100
Issue type
Refactor
Clarity
Clearly specified
Activity status
Active
Tech stack
rust, wasm
Domain
backend

Research direction

Start in crates/perry-codegen-wasm/src/wasm_runtime.js and inspect the definitions of rt.array_join and rt.array_push_spread around line 359. Check that emitted code routes calls through mem_call to __memDispatch, then remove the unused imports. Done when both legacy definitions are gone and the live dispatch paths remain intact.

Written by the indexing model from the issue text.

Description

area:compiler effort:S impact:low platform:wasm type:chore

crates/perry-codegen-wasm/src/wasm_runtime.js still defines handle-based rt.array_join (around line 359, joins with JSON.stringify) and rt.array_push_spread. Emitted code never calls them: every call goes through mem_call to __memDispatch. Their semantics now differ from the live paths fixed in #15051 and #15055, so they should be deleted rather than left to drift.

Dominant language
Rust
Stars
4.9k
Forks
166
Avg merge
6h 5m
Merged PRs (30d)
949

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from PerryTS/perry

All issues in PerryTS/perry

Similar issues

More Rust issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.