wasm/web: o.isPrototypeOf(x) and o.hasOwnProperty(k) throw "Cannot convert undefined or null to object"

Open Beginner friendly
#15,076 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
78/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Domain
backend, tooling

Research direction

Start with crates/perry-codegen-wasm/src/wasm_runtime.js around mem_call, mem_call_i32, and their dispatch tables. Check whether bridge lookup accepts only a table's own properties, then add a perry-codegen-wasm unit test for calls named isPrototypeOf, hasOwnProperty, and propertyIsEnumerable. Done means these calls reach the receiver's method and the test passes; class prototype-chain behavior is tracked separately.

Written by the indexing model from the issue text.

Description

On --target web, calling a method whose name is also an Object.prototype member — isPrototypeOf, hasOwnProperty, propertyIsEnumerable — on an object throws Cannot convert undefined or null to object. The same method called through .call works.

class A {}
class B extends A {}
const base: any = { k: 1 };
const child: any = { own: 2 };
Object.setPrototypeOf(child, base);
const typed: { k: number } = { k: 1 };
const show = (label: string, f: () => any) => { try { console.log(label + ": " + f()); } catch (e: any) { console.log(label + ": threw " + e.message); } };
show("base.isPrototypeOf(child)", () => base.isPrototypeOf(child));
show("Object.prototype.isPrototypeOf({})", () => Object.prototype.isPrototypeOf({}));
show("child.hasOwnProperty('own')", () => child.hasOwnProperty("own"));
show("typed.hasOwnProperty('k')", () => typed.hasOwnProperty("k"));
show("child.propertyIsEnumerable('own')", () => child.propertyIsEnumerable("own"));
show("A.isPrototypeOf(B)", () => A.isPrototypeOf(B));
show("A.prototype.isPrototypeOf(new B())", () => A.prototype.isPrototypeOf(new B()));
show("Object.prototype.hasOwnProperty.call(child, 'own') (control)", () => Object.prototype.hasOwnProperty.call(child, "own"));
case Node 26.12.1 --target web on main
base.isPrototypeOf(child) true threw Cannot convert undefined or null to object
Object.prototype.isPrototypeOf({}) true threw Cannot convert undefined or null to object
child.hasOwnProperty('own') true threw Cannot convert undefined or null to object
typed.hasOwnProperty('k') true threw Cannot convert undefined or null to object
child.propertyIsEnumerable('own') true threw Cannot convert undefined or null to object
A.isPrototypeOf(B) true threw Cannot convert undefined or null to object
A.prototype.isPrototypeOf(new B()) true threw Cannot convert undefined or null to object
Object.prototype.hasOwnProperty.call(child, 'own') (control) true true

Run with perry compile fc.ts --target web -o fc.html, then node scripts/parity_web_host.cjs fc.html. Tested on macOS arm64 against main at 88b1e37142, with Node 26.12.1.

Cause. A method call the emitter does not special-case reaches mem_call under the method's own name, with the receiver as the first argument. mem_call looks that name up with a plain index, __memDispatch[name] (crates/perry-codegen-wasm/src/wasm_runtime.js:1419, and __perryUiDispatch[name] at :1424; mem_call_i32 at :1447). Both tables are object literals, so __memDispatch["isPrototypeOf"] is Object.prototype.isPrototypeOf itself. mem_call calls it as a bridge, coreFn(...args), with no receiver, and it throws. A name that is not an Object.prototype member misses both tables and falls through to __classDispatch(receiver, name, args), which calls the receiver's method. The control is Object.prototype.hasOwnProperty.call(child, "own"), which does not go through the method-name lookup.

Proposed fix. mem_call and mem_call_i32 take only a table's own bridges (Object.prototype.hasOwnProperty.call(table, name)), so these names fall through to __classDispatch like any other method. I'll send a PR with a perry-codegen-wasm unit test.

With that fix, the two class rows stop throwing but print false: A.isPrototypeOf(B) also needs #15053 (B's class value inherits from A's), and A.prototype.isPrototypeOf(new B()) needs instances and class prototypes to share one prototype chain (filed separately).

Dominant language
Rust
Stars
4.9k
Forks
166
Avg merge
6h 5m
Merged PRs (30d)
949

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from PerryTS/perry

All issues in PerryTS/perry

Similar issues

More Rust issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.