Improve figure readability in dark mode
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 62/100
- Issue type
- Documentation
- Clarity
- Mostly clear
- Activity status
- Active
- Tech stack
- r
- Domain
- documentation
Research direction
Start with vignettes/diagram-helpers.Rinc, which explicitly draws pale node fills and white label backgrounds causing the black patches. For vignette plots, locate the chunks rendering check_partner_dependence() and check_residuals() and test the given fig.class = "", dev.args = list(bg = "white") option to disable pkgdown inversion. Note the open design question on whether residual-check plots keep dark-mode adaptation — confirm the choice with maintainers, then rebuild the pkgdown site and inspect README plus APIM/DIM/DSM vignettes in both themes.
Written by the indexing model from the issue text.
Description
The website currently handles figures differently in dark mode:
- The README’s
check_partner_dependence()plot keeps its original colours and white background. - The vignette plots are automatically colour-inverted by pkgdown.
- Model diagrams have transparent canvases, but their pale node fills and white label backgrounds turn black, creating patches against the dark grey page.
Examples: README and APIM vignette.
Diagnostic plots: which appearance works best?
One proposal is to keep check_partner_dependence() plots in their original colours on white backgrounds throughout the documentation. This may make small labels and reference lines easier to read and would match the README.
However, dark plots blend into the page and avoid a large bright area.
For residual-check plots (check_dyad_residuals()), should we retain dark-mode adaptation or also use the original colours on white? Should both diagnostic functions follow the same approach?
Opinions are welcome, particularly about label readability, reference-line visibility, and viewing comfort. Compare examples in both themes before deciding.
Model diagrams
Keep diagrams readable in both themes, with node interiors and label backgrounds blending into the page instead of becoming black patches.
The shared diagram helper explicitly draws pale node fills and white label backgrounds. Some label backgrounds hide arrows behind the text, so simply making every fill transparent could reduce readability.
Implementation notes
For vignette plots that should remain white, these chunk options disable pkgdown’s automatic inversion and override the transparent background:
fig.class = "", dev.args = list(bg = "white")
Diagram changes belong in vignettes/diagram-helpers.Rinc. Preserve the existing layout, labels, and meaning of colours.
Tasks
- Agree on the appearance of partner-dependence and residual-check plots.
- Apply the chosen treatment consistently wherever those plots appear in the documentation.
- Remove unwanted black fills from model diagrams while keeping labels clear of arrows.
- Inspect affected figures in light and dark mode, including the README, APIM/DIM/DSM vignettes, and relevant function-reference pages.
- Check that standalone vignettes remain readable.
- Dominant language
- R
- Stars
- 1
- Forks
- 2
- Avg merge
- 19h 46m
- Merged PRs (30d)
- 40
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from Pascal-Kueng/dyadMLM
-
documentation good first issue priority: low
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
Pascal-Kueng/dyadMLM#92 ·
Maintainers usually reply within 1 day
-
documentation enhancement good first issue priority: low
Difficulty 1/5 Under an hour Newbie friendliness 72/100
Pascal-Kueng/dyadMLM#71 · 3 comments ·
Maintainers usually reply within 1 day
-
documentation enhancement priority: low
Difficulty 1/5 Under an hour Newbie friendliness 85/100
Pascal-Kueng/dyadMLM#69 · 1 comment ·
Maintainers usually reply within 1 day
-
documentation enhancement good first issue priority: low
Difficulty 1/5 Under an hour Newbie friendliness 84/100
Pascal-Kueng/dyadMLM#68 ·
Maintainers usually reply within 1 day
-
documentation enhancement priority: low
Difficulty 1/5 Under an hour Newbie friendliness 90/100
Pascal-Kueng/dyadMLM#67 · 1 comment ·
Maintainers usually reply within 1 day
All issues in Pascal-Kueng/dyadMLM
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 71/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
OHDSI/PatientLevelPrediction#688 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
rfordatascience/tidytuesday#1098 ·