test(dbt): add not-null checks for the order revenue demo's business keys

Open Beginner friendly
  • Is something wrong?
#480 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
82/100
Issue type
Feature
Clarity
Clearly specified
Activity status
Active
Tech stack
python
Domain
data-engineering, testing

Research direction

Start with lakehouse_code/gold/order_revenue/dbt/models/gold/schema.yml and inspect the SQL files in that directory to find the emitted grain columns for both named marts. Add built-in dbt not_null tests for the specified business keys, then run dbt parse and, when a platform is available, the tests against the demo. Done means the tests match emitted columns and the change stays within the order_revenue dbt project.

Written by the indexing model from the issue text.

Description

good first issue help wanted
Why

lakehouse_code/gold/order_revenue/dbt/models/gold/schema.yml lists Gold marts and descriptions but no column tests. A small set of key constraints illustrates dbt's role after Floe validation.

Scope
  • Add built-in dbt not_null data tests for stable grain/grouping columns in mart_order_revenue_by_day (date and region) and mart_order_revenue_margin_by_product (inspect SQL for its actual grain first).
  • Do not introduce packages or test measures that may legitimately be zero/null.
Acceptance
  • Tests match columns actually emitted by each SQL model.
  • dbt parse succeeds; tests pass against the existing demo when a running platform is available.
  • Change stays in the order_revenue dbt project.

Start here: lakehouse_code/gold/order_revenue/dbt/models/gold/{schema.yml,*.sql}.

Contributor notes
  • Keep this to one focused PR; follow AGENTS.md.
  • No Kubernetes cluster should be necessary unless specifically mentioned.
  • For Python changes run uv run --project tools/olf pytest tools/olf/tests and uv run --project tools/olf ruff check tools/olf (or narrower tests while iterating).
Dominant language
Python
Stars
26
Forks
6
Avg merge
6h 44m
Merged PRs (30d)
314

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from OpenLakeForge/openlakeforge

All issues in OpenLakeForge/openlakeforge

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.