test: verify diagnostics collection records kubectl failure without aborting
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 84/100
Research direction
Start with tools/olf/tests/test_diagnostics.py and trace the public collect behavior and its existing mocked Docker failure test. Add a mocked resolver/runner case for unavailable kubectl, then run the focused diagnostics tests. Done when collection does not abort, host-disk.txt and host-memory.txt are written, and at least one Kubernetes diagnostics file explains the failure.
Written by the indexing model from the issue text.
Description
Why
olf diagnostics collect is meant to preserve partial evidence when a command fails. The current tests cover a missing Docker binary but not an unavailable kubectl command.
Scope
- Add a mocked resolver/runner test under
tools/olf/tests/test_diagnostics.pywherekubectlis unavailable. - Confirm text files for the failed probes contain a useful error and host diagnostics are still written.
- No real Docker or Kubernetes calls; test the public
collectbehavior.
Acceptance
- No uncaught error interrupts the collection.
-
host-disk.txtandhost-memory.txtstill exist. - At least one Kubernetes diagnostics file explains the failure.
Contributor notes
- Keep this to one focused PR; follow AGENTS.md.
- No Kubernetes cluster should be necessary unless specifically mentioned.
- For Python changes run
uv run --project tools/olf pytest tools/olf/testsanduv run --project tools/olf ruff check tools/olf(or narrower tests while iterating).
- Dominant language
- Python
- Stars
- 26
- Forks
- 6
- Avg merge
- 12h 26m
- Merged PRs (30d)
- 162
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from OpenLakeForge/openlakeforge
-
bug good first issue help wanted
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
OpenLakeForge/openlakeforge#498 ·
Maintainers usually reply within 1 day
-
bug good first issue help wanted
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
OpenLakeForge/openlakeforge#497 ·
Maintainers usually reply within 1 day
-
feat(cli): export `olf query` output directly to a filePossibly taken @dbdefault claimed this 1 day ago. Openenhancement good first issue help wanted
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
OpenLakeForge/openlakeforge#494 · 1 comment · 1 assignee ·
Maintainers usually reply within 1 day
-
good first issue help wanted
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
OpenLakeForge/openlakeforge#487 ·
Maintainers usually reply within 1 day
-
good first issue help wanted
Difficulty 1/5 1-3 hours Newbie friendliness 85/100
OpenLakeForge/openlakeforge#486 ·
Maintainers usually reply within 1 day
All issues in OpenLakeForge/openlakeforge
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
aws-samples/sample-per-model-bedrock#464 ·
Maintainers usually reply within 1 day
-
lesson-submission pending-review
Difficulty 2/5 1-3 hours Newbie friendliness 67/100
Ikalus1988/MisakaNet#3789 ·
Maintainers usually reply within 1 day
-
Python Volcengine provider returns failures instead of raising themPossibly taken @Ricardo-M-L claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 79/100
agent-infra/sandbox#248 ·
-
[Bug] cloud JSON directory loading assumes a Key field in fsspec listingsPossibly taken @Ricardo-M-L claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
hiyouga/LlamaFactory#10910 ·
Maintainers usually reply within 1 day
-
Bundled uv is never updated and trusts the compromised eMudhra certificatesPossibly taken @FabienDanieau claimed this today. Openbug
Difficulty 2/5 1-3 hours Newbie friendliness 76/100