test: ensure ERP demo shipments reference existing purchase orders
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 88/100
Research direction
Start by reading the existing tests in tools/olf/tests/ and locating the two CSV fixtures under lakehouse_code/bronze/erp/examples/. Add an offline pytest that reads both with csv.DictReader, resolves fixture paths from the repository location, and reports any shipment purchase_order_id missing from purchase_orders.csv. The issue is done when the current fixtures pass and an unknown ID fails with that ID shown; run the listed pytest and Ruff commands.
Written by the indexing model from the issue text.
Description
Why
Demo supplier delivery metrics join shipments to purchase orders; invalid keys can be dropped without explanation.
Scope
- Add a fast offline pytest using
csv.DictReaderto assert everypurchase_order_idinlakehouse_code/bronze/erp/examples/shipments.csvexists inpurchase_orders.csv. - Locate the fixtures relative to the repository, not
cwd. - Follow the style of other
tools/olf/tests/modules; no new test dependencies.
Acceptance
- Existing fixtures pass.
- An unknown shipment purchase order ID makes the test fail with the missing ID shown.
- No live platform needed.
Contributor notes
- Keep this to one focused PR; follow AGENTS.md.
- No Kubernetes cluster should be necessary unless specifically mentioned.
- For Python changes run
uv run --project tools/olf pytest tools/olf/testsanduv run --project tools/olf ruff check tools/olf(or narrower tests while iterating).
- Dominant language
- Python
- Stars
- 26
- Forks
- 6
- Avg merge
- 12h 26m
- Merged PRs (30d)
- 162
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from OpenLakeForge/openlakeforge
-
bug good first issue help wanted
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
OpenLakeForge/openlakeforge#498 ·
Maintainers usually reply within 1 day
-
bug good first issue help wanted
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
OpenLakeForge/openlakeforge#497 ·
Maintainers usually reply within 1 day
-
feat(cli): export `olf query` output directly to a filePossibly taken @dbdefault claimed this today. Openenhancement good first issue help wanted
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
OpenLakeForge/openlakeforge#494 · 1 comment · 1 assignee ·
Maintainers usually reply within 1 day
-
good first issue help wanted
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
OpenLakeForge/openlakeforge#488 ·
Maintainers usually reply within 1 day
-
good first issue help wanted
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
OpenLakeForge/openlakeforge#487 ·
Maintainers usually reply within 1 day
All issues in OpenLakeForge/openlakeforge
Similar issues
-
[oblt-aw][autodoc] Update workflow docs for gh-aw v0.92.5 and detector permission scopePossibly taken @github-actions claimed this today. Open
Difficulty 1/5 1-3 hours Newbie friendliness 88/100
Maintainers usually reply within 1 day
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day
-
roadmap-100
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day
-
comp/tools P2 tool/browser tool/file type/bug
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
NousResearch/hermes-agent#143418 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
python-hyper/uritemplate#164 ·