Widget resizing sometimes starts at incorrect position
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 45/100
Research direction
Start in HomeScreenGrid, in the binding.resizeFrame.onResizeListener handler, and compare the widget's stored left/top/right/bottom with the grid items on the current page. Reproduce by resizing a 3x3 resizable widget with the steps in the issue and checking whether the position jumps after steps 2, 5 and 8. Done means the widget keeps its cell position through repeated resize sessions, without the reporter's workaround of copying the bounds onto every matching grid item.
Written by the indexing model from the issue text.
Description
Checklist
- I can reproduce the bug with the latest version given here.
- I made sure that there are no existing issues - open or closed - to which I could contribute my information.
- I made sure that there are no existing discussions - open or closed - to which I could contribute my information.
- I have read the FAQs inside the app (Menu -> About -> FAQs) and my problem isn't listed.
- I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
- This issue contains only one bug.
- I have read and understood the contribution guidelines.
Affected app version
latest commit 8c3a74aae9451ba0fa23041988b172b62b3cc217, and 1.0.1 release
Affected Android/Custom ROM version
Android 12
Affected device model
Nokia 5.4
How did you install the app?
Built from source
Steps to reproduce the bug
- Add a resizable widget to the homescreen, and resize it to 3x3
- Long press on widget, select resize
- Move left drag point one cell to the right
- Exit resize view
- Resize same widget
- Move left drag point one cell to the left
- Exit resize view
- Resize same widget
Expected behavior
Resizing should work as expected. No unexpected jumps in widget position.
Actual behavior
After step 2, 5 or 8 the widget jumps one cell to the left or right (seemingly dependent on some previous state).
Screenshots/Screen recordings
I can record the issue if you cannot reproduce it.
Additional information
The resizable widget I reproduced the issue with is from my own app, but it does little more than the example widget that was automatically generated.
The issue can be fixed by adding the following to binding.resizeFrame.onResizeListener in HomeScreenGrid, but it seems like a bit of a hack:
gridItems.filterVisibleOnCurrentPageOnly().filter { it.id == item.id }.forEach { gridItem ->
gridItem.left = item.left
gridItem.top = item.top
gridItem.right = item.right
gridItem.bottom = item.bottom
}
- Dominant language
- Kotlin
- Stars
- 703
- Forks
- 85
- Avg merge
- 2d 22h
- Merged PRs (30d)
- 10
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from FossifyOrg/Launcher
-
bug needs triage
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
FossifyOrg/Launcher#453 ·
Maintainers usually reply within 1 day
-
bug needs triage
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
FossifyOrg/Launcher#447 ·
Maintainers usually reply within 1 day
-
bug needs triage
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
FossifyOrg/Launcher#446 ·
Maintainers usually reply within 1 day
-
feature request needs triage
Difficulty 3/5 1-2 days Newbie friendliness 58/100
FossifyOrg/Launcher#465 ·
Maintainers usually reply within 1 day
-
feature request needs triage
Difficulty 3/5 1-2 days Newbie friendliness 40/100
FossifyOrg/Launcher#461 ·
Maintainers usually reply within 1 day
All issues in FossifyOrg/Launcher
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
world-federation-of-advertisers/cross-media-measurement#4653 ·
Maintainers usually reply within 1 day
-
enhancement help wanted
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
kabirvashisht4-glitch/Vet#22 ·
-
documentation good first issue
Difficulty 1/5 1-3 hours Newbie friendliness 85/100
djazairdev/wilayas#23 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 85/100
lysine-dev/okhttp#9788 ·
Maintainers usually reply within 1 day