Option to adjust the color-contrast between keys and background
Maintainers usually reply within 5 days
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 35/100
Research direction
The key-border color comes from darkenColor(2) called in app/src/main/kotlin/org/fossify/keyboard/extensions/Context.kt around line 60; the helper itself is in Fossify Commons, Int.kt near line 98. Start by confirming which value controls the key-to-background contrast, then decide whether to expose it as a setting or change the constant. Maintainers have not chosen an approach, so agree on one in the thread first. Done means the border contrast is visibly stronger or user-adjustable, with the Show key borders setting still working.
Written by the indexing model from the issue text.
Description
Checklist
- I made sure that there are no existing issues - open or closed - to which I could contribute my information.
- I made sure that there are no existing discussions - open or closed - to which I could contribute my information.
- I have read the FAQs inside the app (Menu -> About -> FAQs) and my problem isn't listed.
- I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
- This issue contains only one feature request.
- I have read and understood the contribution guidelines.
- I optionally donated to support the Fossify mission.
Feature description
If you activate the setting "Show key borders", then the keys are brighter than the background. I like this feature, but the color-contrast/-difference between those two colors is currently small. I would prefer a stronger contrast or - even better - that the user can adjust this contrast. Currently this contrast can not be adjusted by the user.
I can think of three solutions for this problem:
-
Give the user an option to select the color of the keys and the color of the background directly and independently.
- The app currently has settings for four colors: text, background, "primary" and for the app icon. Maybe consider changing what the primary color does: currently it changes the color of the Enter-key. Maybe instead the primary color could set the color of the keys.
-
I have had a quick look at the source code and - as far as I understood it - the user selects the key-color directly in the settings, and (if you activate the setting "Show key borders", then) the background-color is chosen automatically by the app with the method
darkenColor(2)(darkenColor()is only used in this app at https://github.com/FossifyOrg/Keyboard/blob/main/app/src/main/kotlin/org/fossify/keyboard/extensions/Context.kt#L60) (The method itself is in Fossify Commons: https://github.com/FossifyOrg/Commons/blob/master/commons/src/main/kotlin/org/fossify/commons/extensions/Int.kt#L98) I guess, that the number 2 sets the contrast between the key-color and background-color (higher number -> stronger contrast). The number 2 can not be changed by the user.
I am not sure if all of this is correct. Please check again.
2 solutions based on this:- Change
.darkenColor(2)in the source code to a stronger contrast (so a higher number than 2?!). This would change the contrast permanently for all users, so it would be better for some people (including me), but maybe worse for other people. - Give the user the option to change this number.
- Change
Why do you want this feature?
The app currently has already got an option for a contrast between the keys and the background (the setting "Show key borders"), but that contrast is small, which makes it hard for me to see where the keys are and where the background is, which makes typing harder. I would prefer a bigger/stronger contrast. This is my biggest reason why I don't want to use Fossify Keyboard.
Additional information
No response
- Dominant language
- Kotlin
- Stars
- 678
- Forks
- 84
- Avg merge
- 5d 9h
- Merged PRs (30d)
- 8
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from FossifyOrg/Keyboard
-
Error of the Ukrainian keyboard layoutPossibly taken A pull request linked to this issue is open or already merged. Openbug
Difficulty 2/5 1-3 hours Newbie friendliness 60/100
FossifyOrg/Keyboard#487 · 1 comment ·
Maintainers usually reply within 5 days
-
bug needs triage
Difficulty 4/5 3-5 days Newbie friendliness 48/100
FossifyOrg/Keyboard#484 ·
Maintainers usually reply within 5 days
-
bug needs triage
Difficulty 3/5 1-2 days Newbie friendliness 35/100
FossifyOrg/Keyboard#462 · 1 comment ·
Maintainers usually reply within 5 days
-
bug needs triage
Difficulty 4/5 3-5 days Newbie friendliness 18/100
FossifyOrg/Keyboard#450 ·
Maintainers usually reply within 5 days
-
feature request needs triage
Difficulty 3/5 1-2 days Newbie friendliness 35/100
FossifyOrg/Keyboard#447 ·
Maintainers usually reply within 5 days
All issues in FossifyOrg/Keyboard
Similar issues
-
Difficulty 1/5 Under an hour Newbie friendliness 73/100
tortuvshin/open-apps#377 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 79/100
supabase-community/supabase-kt#1413 ·
Maintainers usually reply within 5 days
-
Type: Possible bug
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
spacecowboy/Feeder#1258 ·
Maintainers usually reply within 1 day
-
[Submission] 抖音火山版Opensubmit-adaption submit-adaption-pre
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
BetterAndroid/android-notification-icon-project#744 · 1 comment ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 64/100
utopia-rise/godot-jvm#1004 ·
Maintainers usually reply within 1 day