Option to adjust the color-contrast between keys and background
Les mainteneurs répondent en général sous 2 jours
Personne n'a encore pris cette issue.
Évaluation
- Difficulté
- 3/5
- Temps estimé
- 1-2 jours
- Accessibilité débutants
- 35/100
Piste de recherche
The key-border color comes from darkenColor(2) called in app/src/main/kotlin/org/fossify/keyboard/extensions/Context.kt around line 60; the helper itself is in Fossify Commons, Int.kt near line 98. Start by confirming which value controls the key-to-background contrast, then decide whether to expose it as a setting or change the constant. Maintainers have not chosen an approach, so agree on one in the thread first. Done means the border contrast is visibly stronger or user-adjustable, with the Show key borders setting still working.
Rédigé par le modèle d'indexation à partir du texte de l'issue.
Description
Checklist
- I made sure that there are no existing issues - open or closed - to which I could contribute my information.
- I made sure that there are no existing discussions - open or closed - to which I could contribute my information.
- I have read the FAQs inside the app (Menu -> About -> FAQs) and my problem isn't listed.
- I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
- This issue contains only one feature request.
- I have read and understood the contribution guidelines.
- I optionally donated to support the Fossify mission.
Feature description
If you activate the setting "Show key borders", then the keys are brighter than the background. I like this feature, but the color-contrast/-difference between those two colors is currently small. I would prefer a stronger contrast or - even better - that the user can adjust this contrast. Currently this contrast can not be adjusted by the user.
I can think of three solutions for this problem:
-
Give the user an option to select the color of the keys and the color of the background directly and independently.
- The app currently has settings for four colors: text, background, "primary" and for the app icon. Maybe consider changing what the primary color does: currently it changes the color of the Enter-key. Maybe instead the primary color could set the color of the keys.
-
I have had a quick look at the source code and - as far as I understood it - the user selects the key-color directly in the settings, and (if you activate the setting "Show key borders", then) the background-color is chosen automatically by the app with the method
darkenColor(2)(darkenColor()is only used in this app at https://github.com/FossifyOrg/Keyboard/blob/main/app/src/main/kotlin/org/fossify/keyboard/extensions/Context.kt#L60) (The method itself is in Fossify Commons: https://github.com/FossifyOrg/Commons/blob/master/commons/src/main/kotlin/org/fossify/commons/extensions/Int.kt#L98) I guess, that the number 2 sets the contrast between the key-color and background-color (higher number -> stronger contrast). The number 2 can not be changed by the user.
I am not sure if all of this is correct. Please check again.
2 solutions based on this:- Change
.darkenColor(2)in the source code to a stronger contrast (so a higher number than 2?!). This would change the contrast permanently for all users, so it would be better for some people (including me), but maybe worse for other people. - Give the user the option to change this number.
- Change
Why do you want this feature?
The app currently has already got an option for a contrast between the keys and the background (the setting "Show key borders"), but that contrast is small, which makes it hard for me to see where the keys are and where the background is, which makes typing harder. I would prefer a bigger/stronger contrast. This is my biggest reason why I don't want to use Fossify Keyboard.
Additional information
No response
- Langage dominant
- Kotlin
- Étoiles
- 678
- Forks
- 84
- Merge moyen
- 2 j 14 h
- PR mergées (30 j)
- 7
Préparer son environnement
- Aucun Dockerfile ni fichier Docker Compose
- Aucun modèle de pull request
- Lire le guide de contribution
Par où commencer
- Lisez l'issue en entier, puis le guide de contribution du projet.
- Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
- Forkez le dépôt et travaillez sur une branche.
- Ouvrez une pull request qui référence le numéro de l'issue.
Autres issues de FossifyOrg/Keyboard
-
Error of the Ukrainian keyboard layoutPeut-être pris Une pull request liée à cette issue est ouverte ou déjà fusionnée. Ouvertebug
Difficulté 2/5 1-3 heures Accessibilité débutants 60/100
FossifyOrg/Keyboard#487 · 1 commentaire ·
Les mainteneurs répondent en général sous 2 jours
-
feature request needs triage
Difficulté 5/5 Plus d'une semaine Accessibilité débutants 30/100
FossifyOrg/Keyboard#511 · 1 réaction ·
Les mainteneurs répondent en général sous 2 jours
-
bug needs triage
Difficulté 4/5 3-5 jours Accessibilité débutants 48/100
FossifyOrg/Keyboard#484 ·
Les mainteneurs répondent en général sous 2 jours
-
bug needs triage
Difficulté 3/5 1-2 jours Accessibilité débutants 35/100
FossifyOrg/Keyboard#462 · 1 commentaire ·
Les mainteneurs répondent en général sous 2 jours
-
bug needs triage
Difficulté 4/5 3-5 jours Accessibilité débutants 18/100
FossifyOrg/Keyboard#450 ·
Les mainteneurs répondent en général sous 2 jours
Toutes les issues de FossifyOrg/Keyboard
Issues similaires
-
Difficulté 2/5 1-3 heures Accessibilité débutants 62/100
pengchujin/aerial-tv#713 ·
Les mainteneurs répondent en général sous 1 jour
-
bug good first issue
Difficulté 2/5 1-3 heures Accessibilité débutants 83/100
Les mainteneurs répondent en général sous 1 jour
-
needs-triage
Difficulté 2/5 1-3 heures Accessibilité débutants 68/100
Les mainteneurs répondent en général sous 1 jour
-
bug
Difficulté 2/5 1-3 heures Accessibilité débutants 67/100
-
bug
Difficulté 2/5 1-3 heures Accessibilité débutants 67/100
lysine-dev/okhttp#9817 ·
Les mainteneurs répondent en général sous 1 jour