Option to adjust the color-contrast between keys and background
メンテナーはふだん 5 日以内に返信
まだ誰も着手していません。
評価
- 難易度
- 3/5
- 見積もり時間
- 1〜2日
- 初心者へのやさしさ
- 35/100
調査の方向性
The key-border color comes from darkenColor(2) called in app/src/main/kotlin/org/fossify/keyboard/extensions/Context.kt around line 60; the helper itself is in Fossify Commons, Int.kt near line 98. Start by confirming which value controls the key-to-background contrast, then decide whether to expose it as a setting or change the constant. Maintainers have not chosen an approach, so agree on one in the thread first. Done means the border contrast is visibly stronger or user-adjustable, with the Show key borders setting still working.
索引モデルが issue の本文から書いたものです。
説明
Checklist
- I made sure that there are no existing issues - open or closed - to which I could contribute my information.
- I made sure that there are no existing discussions - open or closed - to which I could contribute my information.
- I have read the FAQs inside the app (Menu -> About -> FAQs) and my problem isn't listed.
- I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
- This issue contains only one feature request.
- I have read and understood the contribution guidelines.
- I optionally donated to support the Fossify mission.
Feature description
If you activate the setting "Show key borders", then the keys are brighter than the background. I like this feature, but the color-contrast/-difference between those two colors is currently small. I would prefer a stronger contrast or - even better - that the user can adjust this contrast. Currently this contrast can not be adjusted by the user.
I can think of three solutions for this problem:
-
Give the user an option to select the color of the keys and the color of the background directly and independently.
- The app currently has settings for four colors: text, background, "primary" and for the app icon. Maybe consider changing what the primary color does: currently it changes the color of the Enter-key. Maybe instead the primary color could set the color of the keys.
-
I have had a quick look at the source code and - as far as I understood it - the user selects the key-color directly in the settings, and (if you activate the setting "Show key borders", then) the background-color is chosen automatically by the app with the method
darkenColor(2)(darkenColor()is only used in this app at https://github.com/FossifyOrg/Keyboard/blob/main/app/src/main/kotlin/org/fossify/keyboard/extensions/Context.kt#L60) (The method itself is in Fossify Commons: https://github.com/FossifyOrg/Commons/blob/master/commons/src/main/kotlin/org/fossify/commons/extensions/Int.kt#L98) I guess, that the number 2 sets the contrast between the key-color and background-color (higher number -> stronger contrast). The number 2 can not be changed by the user.
I am not sure if all of this is correct. Please check again.
2 solutions based on this:- Change
.darkenColor(2)in the source code to a stronger contrast (so a higher number than 2?!). This would change the contrast permanently for all users, so it would be better for some people (including me), but maybe worse for other people. - Give the user the option to change this number.
- Change
Why do you want this feature?
The app currently has already got an option for a contrast between the keys and the background (the setting "Show key borders"), but that contrast is small, which makes it hard for me to see where the keys are and where the background is, which makes typing harder. I would prefer a bigger/stronger contrast. This is my biggest reason why I don't want to use Fossify Keyboard.
Additional information
No response
- 主要言語
- Kotlin
- スター
- 678
- フォーク
- 84
- 平均マージ
- 5日 9時間
- マージ済み PR(30日)
- 8
環境構築
- Dockerfile・Docker Compose ファイルなし
- プルリクエストのテンプレートなし
- コントリビューションガイドを読む
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
FossifyOrg/Keyboard のほかの issue
-
Error of the Ukrainian keyboard layout対応中かも このイシューにリンクされたプルリクエストがオープン中、またはマージ済みです。 オープンbug
難易度 2/5 1〜3時間 初心者へのやさしさ 60/100
FossifyOrg/Keyboard#487 · コメント 1 件 ·
メンテナーはふだん 5 日以内に返信
-
bug needs triage
難易度 4/5 3〜5日 初心者へのやさしさ 48/100
FossifyOrg/Keyboard#484 ·
メンテナーはふだん 5 日以内に返信
-
bug needs triage
難易度 3/5 1〜2日 初心者へのやさしさ 35/100
FossifyOrg/Keyboard#462 · コメント 1 件 ·
メンテナーはふだん 5 日以内に返信
-
bug needs triage
難易度 4/5 3〜5日 初心者へのやさしさ 18/100
FossifyOrg/Keyboard#450 ·
メンテナーはふだん 5 日以内に返信
-
feature request needs triage
難易度 3/5 1〜2日 初心者へのやさしさ 35/100
FossifyOrg/Keyboard#447 ·
メンテナーはふだん 5 日以内に返信
FossifyOrg/Keyboard の issue をすべて見る
似ている issue
-
M1 manhwa listオープンBug Domain changed
難易度 2/5 1〜3時間 初心者へのやさしさ 62/100
keiyoushi/extensions-source#19882 ·
メンテナーはふだん 1 日以内に返信
-
難易度 2/5 1〜3時間 初心者へのやさしさ 78/100
メンテナーはふだん 3 日以内に返信
-
bug
難易度 2/5 1〜3時間 初心者へのやさしさ 76/100
lugassawan/swe-workbench#799 ·
メンテナーはふだん 1 日以内に返信
-
Default book icon displayed while loading対応中かも @Bhaskar-Guthula-137 が今日担当しました。 オープンbug good first issue
難易度 2/5 1〜3時間 初心者へのやさしさ 66/100
kiwix/kiwix-android#5194 · コメント 1 件 ·
メンテナーはふだん 1 日以内に返信
-
enhancement
難易度 2/5 1〜3時間 初心者へのやさしさ 68/100
d4rken-org/butler#300 ·
メンテナーはふだん 1 日以内に返信