Option to adjust the color-contrast between keys and background
Los mantenedores suelen responder en 5 días
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 3/5
- Tiempo estimado
- 1-2 días
- Aptitud para principiantes
- 35/100
Línea de trabajo
The key-border color comes from darkenColor(2) called in app/src/main/kotlin/org/fossify/keyboard/extensions/Context.kt around line 60; the helper itself is in Fossify Commons, Int.kt near line 98. Start by confirming which value controls the key-to-background contrast, then decide whether to expose it as a setting or change the constant. Maintainers have not chosen an approach, so agree on one in the thread first. Done means the border contrast is visibly stronger or user-adjustable, with the Show key borders setting still working.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
Checklist
- I made sure that there are no existing issues - open or closed - to which I could contribute my information.
- I made sure that there are no existing discussions - open or closed - to which I could contribute my information.
- I have read the FAQs inside the app (Menu -> About -> FAQs) and my problem isn't listed.
- I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
- This issue contains only one feature request.
- I have read and understood the contribution guidelines.
- I optionally donated to support the Fossify mission.
Feature description
If you activate the setting "Show key borders", then the keys are brighter than the background. I like this feature, but the color-contrast/-difference between those two colors is currently small. I would prefer a stronger contrast or - even better - that the user can adjust this contrast. Currently this contrast can not be adjusted by the user.
I can think of three solutions for this problem:
-
Give the user an option to select the color of the keys and the color of the background directly and independently.
- The app currently has settings for four colors: text, background, "primary" and for the app icon. Maybe consider changing what the primary color does: currently it changes the color of the Enter-key. Maybe instead the primary color could set the color of the keys.
-
I have had a quick look at the source code and - as far as I understood it - the user selects the key-color directly in the settings, and (if you activate the setting "Show key borders", then) the background-color is chosen automatically by the app with the method
darkenColor(2)(darkenColor()is only used in this app at https://github.com/FossifyOrg/Keyboard/blob/main/app/src/main/kotlin/org/fossify/keyboard/extensions/Context.kt#L60) (The method itself is in Fossify Commons: https://github.com/FossifyOrg/Commons/blob/master/commons/src/main/kotlin/org/fossify/commons/extensions/Int.kt#L98) I guess, that the number 2 sets the contrast between the key-color and background-color (higher number -> stronger contrast). The number 2 can not be changed by the user.
I am not sure if all of this is correct. Please check again.
2 solutions based on this:- Change
.darkenColor(2)in the source code to a stronger contrast (so a higher number than 2?!). This would change the contrast permanently for all users, so it would be better for some people (including me), but maybe worse for other people. - Give the user the option to change this number.
- Change
Why do you want this feature?
The app currently has already got an option for a contrast between the keys and the background (the setting "Show key borders"), but that contrast is small, which makes it hard for me to see where the keys are and where the background is, which makes typing harder. I would prefer a bigger/stronger contrast. This is my biggest reason why I don't want to use Fossify Keyboard.
Additional information
No response
- Lenguaje dominante
- Kotlin
- Estrellas
- 678
- Forks
- 84
- Merge medio
- 5 d 9 h
- PR fusionados (30 d)
- 8
Preparar el entorno
- Sin Dockerfile ni archivo de Docker Compose
- Sin plantilla de pull request
- Leer la guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de FossifyOrg/Keyboard
-
Error of the Ukrainian keyboard layoutPosiblemente ocupada Un pull request vinculado a esta issue está abierto o ya se fusionó. Abiertobug
Dificultad 2/5 1-3 horas Aptitud para principiantes 60/100
FossifyOrg/Keyboard#487 · 1 comentario ·
Los mantenedores suelen responder en 5 días
-
bug needs triage
Dificultad 4/5 3-5 días Aptitud para principiantes 48/100
FossifyOrg/Keyboard#484 ·
Los mantenedores suelen responder en 5 días
-
bug needs triage
Dificultad 3/5 1-2 días Aptitud para principiantes 35/100
FossifyOrg/Keyboard#462 · 1 comentario ·
Los mantenedores suelen responder en 5 días
-
bug needs triage
Dificultad 4/5 3-5 días Aptitud para principiantes 18/100
FossifyOrg/Keyboard#450 ·
Los mantenedores suelen responder en 5 días
-
Add support for Georgian layoutAbiertofeature request needs triage
Dificultad 3/5 1-2 días Aptitud para principiantes 35/100
FossifyOrg/Keyboard#447 ·
Los mantenedores suelen responder en 5 días
Todos los issues de FossifyOrg/Keyboard
Issues similares
-
bugbane/qf good first issue
Dificultad 2/5 1-3 horas Aptitud para principiantes 64/100
osservatorionessuno/bugbane#173 ·
Los mantenedores suelen responder en 1 día
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 78/100
-
Bayern feature:Application ready web
Dificultad 2/5 1-3 horas Aptitud para principiantes 67/100
digitalfabrik/entitlementcard#3176 ·
Los mantenedores suelen responder en 7 días
-
bug need-device
Dificultad 2/5 1-3 horas Aptitud para principiantes 64/100
ramesh130/superplayer#495 ·
Los mantenedores suelen responder en 1 día
-
Remove song from playlistAbierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 66/100
maxrave-dev/SimpMusic#2649 ·
Los mantenedores suelen responder en 2 días