Bug Report: Incorrect Cast Time Formatting (ruRU)

Open
#58 1 comment 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
56/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
lua
Domain
frontend

Research direction

Start by comparing the attached Spell.lua with the repository's existing spell tooltip implementation and focus on how textual versus numerical cast times are handled. The issue says the fix belongs in Spell.lua; verify in the ruRU client that textual cast descriptions have no redundant caption or overlap, while numerical cast times retain their caption. Treat the proposed layout adjustments as out of scope.

Written by the indexing model from the issue text.

Description

bug

Sup. I've been trying to Vibecode a fix for cyrrilic bug. Completed it more or less, checked with my hunter and warlock

spell.lua (txt) attached

https://imgur.com/CNECd8Z

Spell.txt

There are some other minor things I've found, but not sure even if they are worth your time

Bug Report: Incorrect Cast Time Formatting (ruRU)

Addon: PrettyTooltip 1.4.0
Client: WoW Forever 1.60.1 (70888)
Locale: ruRU

Original issue

We identified a formatting issue in the Cast Time column of spell tooltips.

For abilities with textual cast descriptions, such as "Мгновенное действие" (Instant Cast) or "Следующая атака" (Next Melee Attack), PrettyTooltip automatically added a separate "ПРИМЕНЕНИЕ" (Cast) caption underneath the text.

This caption was redundant and, in some cases, overlapped with longer descriptions that wrapped onto a second line.

Numerical cast times, such as "1,5 сек.", were already displayed correctly with the smaller "ПРИМЕНЕНИЕ" caption.

Intended fix

The corrected Spell.lua distinguishes between numerical cast times and textual cast descriptions:

  • Numerical cast times: Retain the original value and smaller "ПРИМЕНЕНИЕ" caption.
  • Instant casts: Display "Мгновенное применение" as a single text element without an additional caption.
  • Next-attack abilities: Display "Следующая атака" without an additional caption.

Additional changes and clarification

The fix was developed through several iterations with AI assistance. During those iterations, the AI introduced unnecessary changes to column widths, spacing, and vertical positioning while attempting to resolve the original text-overlap issue.

These layout adjustments were not part of the original bug and should not be considered necessary to fix it.

We subsequently restored the original equal-width column layout and made additional alignment adjustments to correct visual inconsistencies introduced during the AI-assisted revisions.

Result

The final modified file displays numerical cast times and textual cast descriptions correctly, without redundant captions or overlapping text.

The original four-column design is preserved as closely as possible.

Note to the developer: The essential fix is the conditional handling of cast descriptions. The additional layout changes in the attached Spell.lua are primarily consequences of the iterative AI-assisted debugging process and may not be necessary for an official implementation.

The issue and subsequent changes were visually tested in the Russian game client.

Dominant language
Lua
Stars
0
Forks
0
Avg merge
21h 20m
Merged PRs (30d)
5

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from FallenShard/PrettyTooltip

All issues in FallenShard/PrettyTooltip

Similar issues

More Lua issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.