Bug Report: Incorrect Cast Time Formatting (ruRU)

Aperta
#58 1 commento 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
2/5
Tempo stimato
1-3 ore
Idoneità per principianti
56/100
Tipo di issue
Bug
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
lua
Ambito
frontend

Direzione di ricerca

Start by comparing the attached Spell.lua with the repository's existing spell tooltip implementation and focus on how textual versus numerical cast times are handled. The issue says the fix belongs in Spell.lua; verify in the ruRU client that textual cast descriptions have no redundant caption or overlap, while numerical cast times retain their caption. Treat the proposed layout adjustments as out of scope.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

bug

Sup. I've been trying to Vibecode a fix for cyrrilic bug. Completed it more or less, checked with my hunter and warlock

spell.lua (txt) attached

https://imgur.com/CNECd8Z

Spell.txt

There are some other minor things I've found, but not sure even if they are worth your time

Bug Report: Incorrect Cast Time Formatting (ruRU)

Addon: PrettyTooltip 1.4.0
Client: WoW Forever 1.60.1 (70888)
Locale: ruRU

Original issue

We identified a formatting issue in the Cast Time column of spell tooltips.

For abilities with textual cast descriptions, such as "Мгновенное действие" (Instant Cast) or "Следующая атака" (Next Melee Attack), PrettyTooltip automatically added a separate "ПРИМЕНЕНИЕ" (Cast) caption underneath the text.

This caption was redundant and, in some cases, overlapped with longer descriptions that wrapped onto a second line.

Numerical cast times, such as "1,5 сек.", were already displayed correctly with the smaller "ПРИМЕНЕНИЕ" caption.

Intended fix

The corrected Spell.lua distinguishes between numerical cast times and textual cast descriptions:

  • Numerical cast times: Retain the original value and smaller "ПРИМЕНЕНИЕ" caption.
  • Instant casts: Display "Мгновенное применение" as a single text element without an additional caption.
  • Next-attack abilities: Display "Следующая атака" without an additional caption.

Additional changes and clarification

The fix was developed through several iterations with AI assistance. During those iterations, the AI introduced unnecessary changes to column widths, spacing, and vertical positioning while attempting to resolve the original text-overlap issue.

These layout adjustments were not part of the original bug and should not be considered necessary to fix it.

We subsequently restored the original equal-width column layout and made additional alignment adjustments to correct visual inconsistencies introduced during the AI-assisted revisions.

Result

The final modified file displays numerical cast times and textual cast descriptions correctly, without redundant captions or overlapping text.

The original four-column design is preserved as closely as possible.

Note to the developer: The essential fix is the conditional handling of cast descriptions. The additional layout changes in the attached Spell.lua are primarily consequences of the iterative AI-assisted debugging process and may not be necessary for an official implementation.

The issue and subsequent changes were visually tested in the Russian game client.

Lingua principale
Lua
Stelle
0
Fork
0
Merge medio
21h 20m
PR unite (30g)
5

Preparare l'ambiente

Questo progetto non fornisce container di sviluppo, Dockerfile né guida per i contributori, quindi l'ambiente è a tuo carico: parti dal suo README e consulta la nostra guida al primo contributo per i passaggi generali.

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di FallenShard/PrettyTooltip

Tutte le issue di FallenShard/PrettyTooltip

Issue simili

Altre issue su Lua

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.