Bug Report: Incorrect Cast Time Formatting (ruRU)

Abierto
#58 1 comentario 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
2/5
Tiempo estimado
1-3 horas
Aptitud para principiantes
56/100
Tipo de issue
Error
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
lua
Área
frontend

Línea de trabajo

Start by comparing the attached Spell.lua with the repository's existing spell tooltip implementation and focus on how textual versus numerical cast times are handled. The issue says the fix belongs in Spell.lua; verify in the ruRU client that textual cast descriptions have no redundant caption or overlap, while numerical cast times retain their caption. Treat the proposed layout adjustments as out of scope.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

bug

Sup. I've been trying to Vibecode a fix for cyrrilic bug. Completed it more or less, checked with my hunter and warlock

spell.lua (txt) attached

https://imgur.com/CNECd8Z

Spell.txt

There are some other minor things I've found, but not sure even if they are worth your time

Bug Report: Incorrect Cast Time Formatting (ruRU)

Addon: PrettyTooltip 1.4.0
Client: WoW Forever 1.60.1 (70888)
Locale: ruRU

Original issue

We identified a formatting issue in the Cast Time column of spell tooltips.

For abilities with textual cast descriptions, such as "Мгновенное действие" (Instant Cast) or "Следующая атака" (Next Melee Attack), PrettyTooltip automatically added a separate "ПРИМЕНЕНИЕ" (Cast) caption underneath the text.

This caption was redundant and, in some cases, overlapped with longer descriptions that wrapped onto a second line.

Numerical cast times, such as "1,5 сек.", were already displayed correctly with the smaller "ПРИМЕНЕНИЕ" caption.

Intended fix

The corrected Spell.lua distinguishes between numerical cast times and textual cast descriptions:

  • Numerical cast times: Retain the original value and smaller "ПРИМЕНЕНИЕ" caption.
  • Instant casts: Display "Мгновенное применение" as a single text element without an additional caption.
  • Next-attack abilities: Display "Следующая атака" without an additional caption.

Additional changes and clarification

The fix was developed through several iterations with AI assistance. During those iterations, the AI introduced unnecessary changes to column widths, spacing, and vertical positioning while attempting to resolve the original text-overlap issue.

These layout adjustments were not part of the original bug and should not be considered necessary to fix it.

We subsequently restored the original equal-width column layout and made additional alignment adjustments to correct visual inconsistencies introduced during the AI-assisted revisions.

Result

The final modified file displays numerical cast times and textual cast descriptions correctly, without redundant captions or overlapping text.

The original four-column design is preserved as closely as possible.

Note to the developer: The essential fix is the conditional handling of cast descriptions. The additional layout changes in the attached Spell.lua are primarily consequences of the iterative AI-assisted debugging process and may not be necessary for an official implementation.

The issue and subsequent changes were visually tested in the Russian game client.

Lenguaje dominante
Lua
Estrellas
0
Forks
0
Merge medio
21 h 20 min
PR fusionados (30 d)
5

Preparar el entorno

Este proyecto no incluye contenedor de desarrollo, Dockerfile ni guía de contribución, así que la configuración corre por tu cuenta: empieza por su README y consulta nuestra guía para la primera contribución para los pasos generales.

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de FallenShard/PrettyTooltip

Todos los issues de FallenShard/PrettyTooltip

Issues similares

Más issues de Lua

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.