[Retail][zhCN] Enchantment quality icon displayed as raw atlas text

Open Beginner friendly
#66 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
72/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
lua
Domain
backend

Research direction

Read Tooltips/Item.lua at the ItemEnchantmentPermanent handler, especially the colon-matching pattern described in the issue. Reproduce with item 240949 on a zhCN Retail client and compare the displayed enchantment line with the expected name and quality icon. Done means the raw atlas markup no longer appears and both display correctly.

Written by the indexing model from the issue text.

Description

Describe the bug:

When using PrettyTooltip on the Simplified Chinese (zhCN) Retail client, the enchantment line displays raw atlas markup instead of the enchantment name and quality icon.

The following text appears in the tooltip:

Professions-ChatIcon-Quality-12-Tier2:20:20|

Steps to reproduce:

  1. Use the Simplified Chinese (zhCN) Retail client.
  2. Enable PrettyTooltip.
  3. Hover over an enchanted item with a crafting quality icon.
  4. The enchantment line displays raw atlas markup.

Expected behavior:

The enchantment name and its corresponding quality icon should be displayed correctly.

Possible cause:

The issue may be related to the following pattern in Tooltips/Item.lua, inside the ItemEnchantmentPermanent handler:

text:match("^[^:]-:%s*(.+)$") or text

The zhCN client may use a full-width colon (:) or omit the colon entirely. Consequently, this pattern may incorrectly match the colon inside the atlas markup (|A:), removing the enchantment name and breaking the atlas formatting.

This is a suspected cause and has not been verified in-game.

Environment:

Game: World of Warcraft Retail
Client locale: Simplified Chinese (zhCN)
Item ID: 240949

Screenshot:

See the attached screenshot.

Thank you for your work on this addon!

A
Dominant language
Lua
Stars
0
Forks
0
Avg merge
21h 20m
Merged PRs (30d)
5

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from FallenShard/PrettyTooltip

All issues in FallenShard/PrettyTooltip

Similar issues

More Lua issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.