Cannot have comments in `@PCode`

Open
  • Is something wrong?
#76 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
58/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Quiet
Tech stack
rust
Domain
compilers

Research direction

Start with src/internal/as2_codegen/statement.rs, especially the reported line 110, and trace how @PCode actions are parsed and reported. Check for existing tests covering inline PCode and diagnostics. Done means comments in the example are accepted and invalid actions produce a more specific error.

Written by the indexing model from the issue text.

Description

The following code fails with the following panic.

@PCode {
    // hello
    Push 0
    Trace
}

thread 'main' ([...]) panicked at [...]/rascal-0.3.5/src/internal/as2_codegen/statement.rs:110:37:
error: invalid action name
  ╭▸ inline pcode
  │

It would be nice if:

  1. the error message was more specific,
  2. comments were supported in @PCode blocks.
Dominant language
Rust
Stars
22
Forks
2
No merged PRs in 30d

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from Dinnerbone/Rascal

All issues in Dinnerbone/Rascal

Similar issues

More Rust issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.