rust_analyzer flycheck: no CLI way to enable clippy from `check.overrideCommand`
Maintainers usually reply within 2 days
Nobody has claimed this yet.
- #4393 by @TrapsterDK — closed without merging
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 77/100
Research direction
Start with tools/rust_analyzer/bin/flycheck.rs; inspect how Args parses --output-base and how user_config.json currently supplies the clippy setting. Add CLI options that override that setting, then check the existing flycheck tests or add coverage for both flags and the config fallback. Done means overrideCommand can enable or disable clippy without writing user_config.json.
Written by the indexing model from the issue text.
Description
tools/rust_analyzer/bin/flycheck.rs adds the clippy aspect only when <launcher_dir>/user_config.json has "clippy": true. There is no flag or env var for it.
Editors that call flycheck through rust-analyzer.check.overrideCommand (override mode, --saved-file $saved_file) can't turn clippy on from their own settings. The only way is to write user_config.json next to the flycheck binary. Tools that copy flycheck somewhere else have to write that file too.
Proposal: add --clippy / --no-clippy to flycheck's Args. They override user_config.json the same way --output-base already overrides output_base. The discover runnable stays the same for every user; the flags are meant for overrideCommand, where the settings are per user already.
Assisted by Claude.
- Dominant language
- Starlark
- Stars
- 854
- Forks
- 684
- Avg merge
- 2d 22h
- Merged PRs (30d)
- 21
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from bazelbuild/rules_rust
-
MSVC stdlib_linkflags miss kernel32.lib and ntdll.libPossibly taken @TrapsterDK claimed this 3 days ago. Openneeds-triage
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
bazelbuild/rules_rust#4375 ·
Maintainers usually reply within 2 days
-
`rust_test(crate = ...)` does not stage the crate's transitive dynamic libraries into runfilesPossibly taken @Wito-1 claimed this 38 days ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
bazelbuild/rules_rust#4309 ·
Maintainers usually reply within 2 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
bazelbuild/rules_rust#4266 ·
Maintainers usually reply within 2 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
bazelbuild/rules_rust#4223 ·
Maintainers usually reply within 2 days
-
Difficulty 1/5 1-3 hours Newbie friendliness 90/100
bazelbuild/rules_rust#4152 · 1 reaction ·
Maintainers usually reply within 2 days
All issues in bazelbuild/rules_rust
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 79/100
microsoft/monaco-editor#5575 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 2 days
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
Maintainers usually reply within 1 day
-
feature request
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
callstack/react-native-paper#5189 ·
Maintainers usually reply within 1 day