Embedded @PCode can't have strings with `}` character

Open
  • Is something wrong?
#1 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
38/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
rust
Domain
compilers

Research direction

Start by locating the lexer for @PCode tags and reading how it currently balances braces; then inspect the pcode lexer to understand how it identifies actual brace tokens. Done means a } inside a string no longer ends the tag, while real brace tokens still determine its boundary. The issue names no files or tests.

Written by the indexing model from the issue text.

Description

Reproduction:

@PCode {
    Push "}"
}

The lexing of @PCode tags is too simple, and just looks for an unbalanced amount of } compared {. We should probably use the pcode lexer and count actual {/} tokens, instead.

Dominant language
Rust
Stars
22
Forks
2
No merged PRs in 30d

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from Dinnerbone/Rascal

All issues in Dinnerbone/Rascal

Similar issues

More Rust issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.