CLI: a Go or Python project with a tooling-only package.json gets no full test command
Maintainers usually reply within 1 day
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 30/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Stale
- Tech stack
- go, python, typescript
Research direction
Start with inferFullCommand in packages/diffci-cli/src/client/full-command.ts and trace how it handles a root package.json without a test script before checking Go and Python project files. Reproduce with the Python or Go setup in the issue and run diffci verify --changed. Done when a tooling-only package.json no longer blocks full command inference, while the two stated package.json cases retain their behavior; pull request #293 is already open.
Written by the indexing model from the issue text.
Description
inferFullCommand (packages/diffci-cli/src/client/full-command.ts) returns { reason: "package.json has no test script" } as soon as it finds a root package.json without a test script. It never reaches the go.mod and Python checks below it. Many Go and Python repositories keep a package.json only for tooling (prettier, husky, commitlint). For them the full command is never inferred, though the engine selects their tests as Go or Python tests.
Repro: a Python project: pyproject.toml, app.py, tests/test_app.py (pytest), and a package.json with only {"private": true, "devDependencies": {"prettier": "3.0.0"}}. Commit it, edit pyproject.toml (a configuration change, which needs the full suite), and run diffci verify --changed. The Go equivalent is go.mod plus the same package.json.
Expected: the full command is python3 -m pytest (or go test ./...), as without the package.json.
Actual: verify is BLOCKED with "package.json has no test script". inferFullCommand returns that reason for the repository directly.
A package.json that does have a test script still wins, and a package.json with no test script and no other project still reports "package.json has no test script".
- Dominant language
- TypeScript
- Stars
- 0
- Forks
- 4
- Avg merge
- 18h 41m
- Merged PRs (30d)
- 48
Getting set up
Starts the project's dev container in your browser, under your own GitHub account.
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from DiffCI/core
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
Planner: splitParts regex is quadratic on a quote followed by many backticks, so the fuzz test fails at randomPossibly taken @FredApps claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
Maintainers usually reply within 1 day
-
Agent tools: changed_files lists only the new path of a renamed filePossibly taken @FredApps claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
Maintainers usually reply within 1 day
-
adapter good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
Maintainers usually reply within 1 day
Similar issues
-
agent-ready area: ui-server priority: p3 type: test
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
schlessera/brain-kit#4249 ·
Maintainers usually reply within 1 day
-
documentation tool triaged
Difficulty 2/5 1-3 hours Newbie friendliness 73/100
can1357/oh-my-pi#19608 · 2 comments ·
Maintainers usually reply within 1 day
-
dependencies tech-debt
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
bcgov/nr-waste-plus#1549 ·
Maintainers usually reply within 1 day
-
enhancement good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
blixvip/solana-token-meta#17 ·
-
enhancement good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
blixvip/solana-tx-parse#18 ·