CLI: a Go or Python project with a tooling-only package.json gets no full test command

Offen
#292 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Maintainer antworten meist innerhalb von 1 Tag

@FredApps arbeitet bereits daran.

Seit 17.11.2026.

  • #293 von @FredApps — offen

Bewertung

Schwierigkeit
2/5
Geschätzter Aufwand
1-3 Stunden
Anfängerfreundlichkeit
30/100
Issue-Typ
Bug
Klarheit
Klar beschrieben
Aktivitätsstatus
Veraltet
Tech-Stack
go, python, typescript
Bereich
cli, testing

Rechercherichtung

Start with inferFullCommand in packages/diffci-cli/src/client/full-command.ts and trace how it handles a root package.json without a test script before checking Go and Python project files. Reproduce with the Python or Go setup in the issue and run diffci verify --changed. Done when a tooling-only package.json no longer blocks full command inference, while the two stated package.json cases retain their behavior; pull request #293 is already open.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

inferFullCommand (packages/diffci-cli/src/client/full-command.ts) returns { reason: "package.json has no test script" } as soon as it finds a root package.json without a test script. It never reaches the go.mod and Python checks below it. Many Go and Python repositories keep a package.json only for tooling (prettier, husky, commitlint). For them the full command is never inferred, though the engine selects their tests as Go or Python tests.

Repro: a Python project: pyproject.toml, app.py, tests/test_app.py (pytest), and a package.json with only {"private": true, "devDependencies": {"prettier": "3.0.0"}}. Commit it, edit pyproject.toml (a configuration change, which needs the full suite), and run diffci verify --changed. The Go equivalent is go.mod plus the same package.json.

Expected: the full command is python3 -m pytest (or go test ./...), as without the package.json.

Actual: verify is BLOCKED with "package.json has no test script". inferFullCommand returns that reason for the repository directly.

A package.json that does have a test script still wins, and a package.json with no test script and no other project still reports "package.json has no test script".

Vorherrschende Sprache
TypeScript
Sterne
0
Forks
4
Ø Merge
18 Std. 41 Min.
Gemergte PRs (30 T.)
48

Entwicklungsumgebung

In Codespaces öffnen

Startet den Dev-Container des Projekts im Browser, mit Ihrem eigenen GitHub-Konto.

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus DiffCI/core

Alle Issues in DiffCI/core

Ähnliche Issues

Weitere Issues zu TypeScript

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.