Agent tools: changed_files lists only the new path of a renamed file
Maintainers usually reply within 1 day
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 88/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- git, typescript
- Domain
- tooling
Research direction
Read packages/diffci-cli/src/client/agent-selection.ts and compare its changed-path reads with gate-checks.ts and working-tree.ts, which the issue says already pass --no-renames. Reproduce with a committed file renamed using git mv, then call diffci_changed_files or agentChangedFiles(repo). Done when the reported changed_files includes both new and old paths; the issue says engine selection is unaffected.
Written by the indexing model from the issue text.
Description
changedPaths in packages/diffci-cli/src/client/agent-selection.ts runs git diff --name-only without --no-renames. With git's default rename detection, a renamed file is listed only under its new path. So diffci_changed_files (agentChangedFiles) and the changed_files of diffci_select_tests (agentSelection) omit the old path. Anything that imported the old path is affected too. Every other changed-path read in the CLI (gate-checks.ts, working-tree.ts) already passes --no-renames.
Repro: commit src/old.ts, then git mv src/old.ts src/new.ts and call diffci_changed_files (or agentChangedFiles(repo)).
Expected: changed_files is ["src/new.ts", "src/old.ts"].
Actual: changed_files is ["src/new.ts"].
The engine's own selection is not affected. Only the reported changed_files list is.
- Dominant language
- TypeScript
- Stars
- 0
- Forks
- 4
- Avg merge
- 18h 41m
- Merged PRs (30d)
- 48
Getting set up
Starts the project's dev container in your browser, under your own GitHub account.
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from DiffCI/core
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
Planner: splitParts regex is quadratic on a quote followed by many backticks, so the fuzz test fails at randomPossibly taken @FredApps claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
Maintainers usually reply within 1 day
-
adapter good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
Maintainers usually reply within 1 day
-
adapter bug good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
Maintainers usually reply within 1 day
Similar issues
-
agent-ready area: ui-server priority: p3 type: test
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
schlessera/brain-kit#4249 ·
Maintainers usually reply within 1 day
-
documentation tool triaged
Difficulty 2/5 1-3 hours Newbie friendliness 73/100
can1357/oh-my-pi#19608 · 2 comments ·
Maintainers usually reply within 1 day
-
dependencies tech-debt
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
bcgov/nr-waste-plus#1549 ·
Maintainers usually reply within 1 day
-
enhancement good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
blixvip/solana-token-meta#17 ·
-
enhancement good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
blixvip/solana-tx-parse#18 ·