Tests: pytest settings from `tox.ini` and `setup.cfg`

Open Beginner friendly
#161 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
88/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
typescript
Domain
ci-cd, testing

Research direction

Start with tests/repo/python-adapter.test.ts and the existing fixtures for pytest.ini and pyproject.toml; read how they test readPytestSettings. Add synthetic fixtures and tests for both keys in tox.ini [pytest] and setup.cfg [tool:pytest], including an indented continuation and the fallback when tox.ini has no [pytest]. Run npm test; if a test reveals incorrect behavior, report it separately as the issue requests.

Written by the indexing model from the issue text.

Description

adapter good first issue

readPytestSettings reads [pytest] from tox.ini and [tool:pytest] from setup.cfg. tests/repo/python-adapter.test.ts only covers pytest.ini and pyproject.toml.

Done when: there are tests for:

  • python_files and testpaths from tox.ini [pytest], including a value continued on an indented line
  • the same keys from setup.cfg [tool:pytest]
  • a tox.ini without [pytest] that's skipped in favour of setup.cfg

This is test-only. If a test shows wrong behaviour, open a bug with the failing case instead of fixing it in the same PR.


New to DiffCI? See CONTRIBUTING.md: add a synthetic fixture, run npm test, and sign off commits with git commit -s. Comment here to claim the issue.

Dominant language
TypeScript
Stars
0
Forks
4
Avg merge
18h 41m
Merged PRs (30d)
48

Getting set up

Open in Codespaces

Starts the project's dev container in your browser, under your own GitHub account.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from DiffCI/core

All issues in DiffCI/core

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.