Declared inputs and alwaysRunTests find no pytest or Maven tests

Open
#271 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

@FredApps is already working on this.

Since Nov 17, 2026.

  • #272 by @FredApps — open

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Stale
Tech stack
typescript
Domain
ci-cd, testing

Research direction

Start in src/repo/impact.ts and trace how knownTestPaths is populated from profile.tests, then how declared input and alwaysRunTests globs select tests. Reproduce with the pytest examples in the issue, then check the Maven case under src/test/java/**. Done means matching pytest and Maven tests are selected for declared inputs and always-run globs; an open linked pull request (#272) is already addressing this issue.

Written by the indexing model from the issue text.

Description

In src/repo/impact.ts, knownTestPaths only collects graph nodes while iterating profile.tests, the JavaScript test locations. pytest and Maven repositories have none, so the list is empty:

  • every declared input in diffci.json fails with "Declared input ... selects no tests; full validation required", even when its tests glob matches real tests;
  • alwaysRunTests globs select nothing, so the listed tests are silently not run.

Repro: pytest repository (testpaths = ["tests"]) with diffci.json {"inputs": [{"files": ["data/model.bin"], "tests": ["tests/test_model.py"]}]}. Change data/model.bin. For the second case, set alwaysRunTests: ["tests/test_smoke.py"] and change any module.

Expected: tests/test_model.py is selected; tests/test_smoke.py is always added.

Actual: full fallback for the declared input; tests/test_smoke.py is missing from the affected tests. Maven (src/test/java/**) behaves the same.

This means the workaround mentioned in #255 falls back rather than selecting tests. Related: #162.

Dominant language
TypeScript
Stars
0
Forks
4
Avg merge
18h 41m
Merged PRs (30d)
48

Getting set up

Open in Codespaces

Starts the project's dev container in your browser, under your own GitHub account.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from DiffCI/core

All issues in DiffCI/core

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.