Declared inputs and alwaysRunTests find no pytest or Maven tests

未关闭
#271 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

@FredApps 已经在做这个了。

开始于 2026年11月17日。

  • #272 来自 @FredApps —— 未关闭

评估

难度
3/5
预计耗时
1-2 天
新手友好度
35/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
停滞
技术栈
typescript
领域
ci-cd, testing

调研方向

Start in src/repo/impact.ts and trace how knownTestPaths is populated from profile.tests, then how declared input and alwaysRunTests globs select tests. Reproduce with the pytest examples in the issue, then check the Maven case under src/test/java/**. Done means matching pytest and Maven tests are selected for declared inputs and always-run globs; an open linked pull request (#272) is already addressing this issue.

由索引模型根据 Issue 内容生成。

描述

In src/repo/impact.ts, knownTestPaths only collects graph nodes while iterating profile.tests, the JavaScript test locations. pytest and Maven repositories have none, so the list is empty:

  • every declared input in diffci.json fails with "Declared input ... selects no tests; full validation required", even when its tests glob matches real tests;
  • alwaysRunTests globs select nothing, so the listed tests are silently not run.

Repro: pytest repository (testpaths = ["tests"]) with diffci.json {"inputs": [{"files": ["data/model.bin"], "tests": ["tests/test_model.py"]}]}. Change data/model.bin. For the second case, set alwaysRunTests: ["tests/test_smoke.py"] and change any module.

Expected: tests/test_model.py is selected; tests/test_smoke.py is always added.

Actual: full fallback for the declared input; tests/test_smoke.py is missing from the affected tests. Maven (src/test/java/**) behaves the same.

This means the workaround mentioned in #255 falls back rather than selecting tests. Related: #162.

主要语言
TypeScript
星标
0
派生
4
平均合并
18 小时 41 分钟
30 天内合并 PR
48

环境准备

在 Codespaces 中打开

在浏览器里用你自己的 GitHub 账号启动这个项目的开发容器。

  • 没有 Dockerfile 或 Docker Compose 文件
  • 没有 Pull Request 模板
  • 阅读贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

DiffCI/core 的其他 Issue

查看 DiffCI/core 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。