feat(bericht): the PDF is A4-only, with column widths tuned to hardcoded German headers
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 40/100
- Issue type
- Feature
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- csharp
- Domain
- desktop, documentation
Research direction
Start with IncidentReportDocument.cs and AttachmentCaptionSection.cs to trace where A4 is selected, then read RolesSection.cs for the seven column widths and German headings. Check IncidentSettings for where a paper-size choice could live, and Formatting.cs for the shared date format; the issue also references #350 for UI string mechanisms. Done means supporting A4/Letter and fitting column widths to measured header text, while accounting for the report’s German strings.
Written by the indexing model from the issue text.
Description
From a portability review of main (ecb341b). Small and mechanical; grouped here because both halves live in LageBuch.Documents.
A4 is hardcoded
src/LageBuch.Documents/IncidentReportDocument.cs:56 page.Size(PageSizes.A4);
src/LageBuch.Documents/Sections/AttachmentCaptionSection.cs:32 page.Size(PageSizes.A4);
Margins are 1.5f, Unit.Centimetre. There is no Letter path and no setting. RolesSection.cs sizes its seven columns explicitly against "A4 portrait", so the page size is not purely a container — the column widths are tuned to it.
The section and column headings are hardcoded German arrays
e.g. RolesSection.cs:10 — ["Funktion", "Name", "Abschnitt", "Funkrufname", "Handynummer", "Von", "Bis"], plus "Einsatzdokumentation", "Einsatztagebuch (ETB)", "Kräfteübersicht", "Atemschutzüberwachung", "CO-Messprotokoll", "Angehängte Dateien", "Gesamtstärke: ", and the footer "Seite {n} / {total}". Roughly 42 distinct German literals across the assembly.
The PDF is also where the one de-DE CultureInfo in the codebase surfaces — Formatting.Timestamp (Formatting.cs:9,11, dd.MM.yyyy HH:mm) is shared by the report and the UI.
Why file it separately from #350
#350 is about the mechanism for UI strings. The report has two things the UI does not: column widths that are coupled to the chosen strings and the chosen page size, and an output that leaves the machine and gets filed. Whatever #350 decides, someone still has to re-fit RolesSection's seven columns when the headers change length — that work is specific to this assembly and worth knowing about before the i18n approach is chosen, not after.
Concretely: a paper-size setting (A4/Letter) on IncidentSettings, and the column widths derived from measured header text rather than tuned constants.
- Dominant language
- C#
- Stars
- 1
- Forks
- 3
- Avg merge
- 4h 34m
- Merged PRs (30d)
- 182
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from CodeForFire/lagebuch
-
bug ux
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
CodeForFire/lagebuch#714 ·
Maintainers usually reply within 1 day
-
bug ux
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
CodeForFire/lagebuch#713 ·
Maintainers usually reply within 1 day
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
CodeForFire/lagebuch#405 ·
Maintainers usually reply within 1 day
-
documentation good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
CodeForFire/lagebuch#349 ·
Maintainers usually reply within 1 day
-
documentation good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
CodeForFire/lagebuch#348 ·
Maintainers usually reply within 1 day
All issues in CodeForFire/lagebuch
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Maintainers usually reply within 1 day
-
bug priority: P2
Difficulty 1/5 Under an hour Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
IridiumIO/CompactGUI#699 ·
Maintainers usually reply within 3 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 73/100
Maintainers usually reply within 1 day
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day